-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Fix CR Status update in Workspace controller #457
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
30c9957
to
acf24d9
Compare
2097861
to
41a2d1e
Compare
6ddc265
to
e6791c4
Compare
e6791c4
to
5ca3f22
Compare
alexsomesan
approved these changes
Aug 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to update the way the workspace controller updates CR Status. It now uses the
patch
method instead ofupdate
. This primarily helps with the edge case when the CR gets updated during initial reconciliation. In this situation, the controller fails to perform an update operation, leading to a scenario where the Workspace is created in HCP Terraform, but the CR status does not have information about the Workspace ID. Consequently, it attempts to create it again once it recovers from the failure. The controller will continue to fail because the name is already taken.This PR mainly fixes the Workspace controller, however, the same issue can happen with other controllers. We need to revise all controllers' logic along with predicate logic(described in this PR) to make it more flexible, straightforward, and clean.
Tests
Usage Example
N/A.
References
Community Note