Handle API pagination #426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtdoepke
force-pushed
the
paginate-lists
branch
3 times, most recently
from
e780a15 to
4edee4d
Compare
|
Hi @jtdoepke, This is indeed a thing that we have missed. Could you please rebase your PR? I will then review it and we could add this fix to the 2.6.0 release(ETA this month). Thanks! |
Calls to Terraform Cloud API endpoints that are paginated should handle that pagination.
|
@arybolovlev done. |
arybolovlev
requested changes
Jul 15, 2024
There was a problem hiding this comment.
Hi @jtdoepke,
All in all, everything looks good. Could you please add PageSize: maxPageSize, to the option list?
Thanks!
Set the page size to 100 to speed up pagination.
arybolovlev
approved these changes
Jul 17, 2024
There was a problem hiding this comment.
Thank you for this fix, @jtdoepke! 🚀 It will be available in 2.6.0 release. ETA end of July.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We encountered a bug where some workspaces that should have had run triggers added by the operator did not have them. We suspected it was due to the controller not handling pagination. I'm no longer sure that's the source of our bug, but it still seems reasonable that any calls to a Terraform Cloud API endpoint that is paginated should handle that pagination.
Usage Example
N/A
References
N/A
Community Note