Coverage test

[KaushikiAnand]

• I have added unit test coverage in the go-multierror.yml workflow
• The unit test coverage change was done to help understand the defects early in lifecycle and come up with a good solution for it.

[ghost]

Question: Why did we need to add difference checks for windows and other OS, was this not working fine before ?

[KaushikiAnand]

yes on running the cmd "go test -v -race -coverprofile=coverage.out ./...", the coverage.out was not being generated for windows. I found this error while working on go-multierror repo and this solution solved the error. So that is why i wrote different checks for windows and other OS.

[ghost]

can you check if go test -v -race -coverprofile="coverage.out" ./... can be used for other OS ? because adding if conditions in workflow will decrease readability

[KaushikiAnand]

okay will look into it.

[KaushikiAnand]

go test -v -race -coverprofile="coverage.out" ./... this can bee used for other OS also. so changed changed it accordingly.

[ghost]

Question: Why do we need different statements here ? Both the run commands are same

[KaushikiAnand]

for windows after run cmd i have added a "shell: cmd" as it runs it in a shell env instead of powershell.
When running the this cmd "go tool cover -func=coverage.out", the display of the coverage report was not occurring, so in order to solve this error, i had to write my ci workflow in this way.

[ghost]

The coverage display for any one of the OS should be fine because the test coverage will be independent of the OS. You can add just the following code and add a comment the coverage might not be visible for windows

        - name: Display coverage report
          run: go tool cover -func=coverage.out

[KaushikiAnand]

suggested changes made