Include parameter validation is a maintenance problem for new valid include options #765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonc
force-pushed
the
TF-9178-go-tfe-gh-issue-764-project-name-attr-is-not-returned-properly
branch
from
4d8fbf6 to
7c57ef0
Compare
We will forgot to add new ones to the validation and the server will validate them for us.
brandonc
force-pushed
the
TF-9178-go-tfe-gh-issue-764-project-name-attr-is-not-returned-properly
branch
from
7c57ef0 to
bdbd165
Compare
laurenolivia
reviewed
Sep 8, 2023
| @@ -887,6 +887,16 @@ func checkResponseCode(r *http.Response) error { | |||
| var err error | |||
|
|
|||
| switch r.StatusCode { | |||
| case 400: | |||
laurenolivia
approved these changes
Sep 8, 2023
brandonc
deleted the
TF-9178-go-tfe-gh-issue-764-project-name-attr-is-not-returned-properly
branch
|
Reminder to the contributor that merged this PR: if your changes have added important functionality or fixed a relevant bug, open a follow-up PR to update CHANGELOG.md with a note on your changes. |
|
Updated CHANGELOG b89bf09 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We have forgotten to add new ones to the validation, the server will validate them for us, and the string is already typed. Note that the API behavior is identical with the same error being returned but only after a round trip to the server.
Example server error response (400)