Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update policy_set to support excluded workspaces relation on CREATE #757

Merged
merged 14 commits into from
Aug 31, 2023
Merged

Update policy_set to support excluded workspaces relation on CREATE #757

merged 14 commits into from
Aug 31, 2023

Conversation

Netra2104
Copy link
Contributor

@Netra2104 Netra2104 commented Aug 16, 2023 •
edited
Loading

Description

This PR provide users with the ability to not apply workspaces when creating a new policy set. This feature is currently behind a feature flag in production.

Testing plan

Integration test is added to complete the testing plan

External links

API documentation

Output from tests

/Users/netra.mali/go/go1.19.11/bin/go tool test2json -t /Users/netra.mali/Library/Caches/JetBrains/GoLand2023.2/tmp/GoLand/___TestPolicySetsCreate_with_policies_and_excluded_workspaces_provided_in_github_com_hashicorp_go_tfe.test -test.v -test.paniconexit0 -test.run ^\QTestPolicySetsCreate\E$/^\Qwith_policies_and_excluded_workspaces_provided\E$
=== RUN   TestPolicySetsCreate
--- PASS: TestPolicySetsCreate (2.35s)
=== RUN   TestPolicySetsCreate/with_policies_and_excluded_workspaces_provided
    --- PASS: TestPolicySetsCreate/with_policies_and_excluded_workspaces_provided (1.42s)
PASS

@Netra2104 Netra2104 force-pushed the Netra2104/TF-7896-post-patch-excluded-workspace branch from ee82dd8 to 78c4c07 Compare August 23, 2023 19:57
@Netra2104 Netra2104 marked this pull request as ready for review August 25, 2023 17:31
@Netra2104 Netra2104 requested a review from a team as a code owner August 25, 2023 17:31
@Netra2104 Netra2104 requested a review from rberecka August 25, 2023 17:32
rberecka
rberecka reviewed Aug 25, 2023
View reviewed changes
brandonc
brandonc previously approved these changes Aug 25, 2023
View reviewed changes
@Netra2104 Netra2104 force-pushed the Netra2104/TF-7896-post-patch-excluded-workspace branch from 4761fd6 to a10725c Compare August 29, 2023 13:56
brandonc
brandonc reviewed Aug 29, 2023
View reviewed changes
@Netra2104 Netra2104 force-pushed the Netra2104/TF-7896-post-patch-excluded-workspace branch from 6965f57 to 65b85d8 Compare August 30, 2023 14:55
@Netra2104 Netra2104 requested a review from brandonc August 30, 2023 20:50
@Netra2104 Netra2104 merged commit a1edca1 into main Aug 31, 2023
@Netra2104 Netra2104 deleted the Netra2104/TF-7896-post-patch-excluded-workspace branch August 31, 2023 13:18
@github-actions
Copy link

Reminder to the contributor that merged this PR: if your changes have added important functionality or fixed a relevant bug, open a follow-up PR to update CHANGELOG.md with a note on your changes.

@hs26gill hs26gill mentioned this pull request Sep 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rberecka rberecka rberecka left review comments

@brandonc brandonc brandonc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Netra2104 @brandonc @rberecka @netramali