-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add UpdateAllowedWorkspaces method to Agent Pool #701
Add UpdateAllowedWorkspaces method to Agent Pool #701
Conversation
a0999ec
to
648dd3b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! I think we could combine the changelog entries into a single bugfix entry but this implementation feels good.
648dd3b
to
bc218da
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!!
bc218da
to
5956999
Compare
1a6c3c9
to
af73eac
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a test for when UpdateAllowedWorkspaces
is called with AgentPoolAllowedWorkspacesUpdateOptions{}
? 🙏
af73eac
to
25a07e6
Compare
Cleared with uturunku1 offline, will get re-reviewed
Co-authored-by: UKEME BASSEY <[email protected]>
92f7f87
to
79e6824
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Reminder to the contributor that merged this PR: if your changes have added important functionality or fixed a relevant bug, open a follow-up PR to update CHANGELOG.md with a note on your changes. |
Description
This pull request is a bug fix to the Agent Pool resource that would enable users to remove all allowed workspaces from an agent pool. AgentPool
Update
was previously not able to accomplish this, soUpdateAllowedWorkspaces
method is exclusively added to allow user to make this request. To facilitate this change, theAllowed-Workspaces
attribute has been relocated from theAgentPoolUpdateOptions
struct to a new struct namedAgentPoolAllowedWorkspacesUpdateOptions
.This modification is necessary to provide users with the ability to clear all allowed workspaces and set it to an empty value. Alternatively, users can use the existing
Update
method to modify other attributes of the agent pool while retaining the current allowed workspaces.Testing plan
Integration tests have been added to cover this section
External links
Output from tests