-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ExpiredAt to Organization, Team, User Authentication Tokens #672
Add ExpiredAt to Organization, Team, User Authentication Tokens #672
Conversation
0d22df7
to
931db0d
Compare
fe42f7b
to
80b4c73
Compare
c41f298
to
061e1bc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Just a few additional suggested assertions
fdd2c36
to
bdc28e7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few corrections on the TFE release, but looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that these are our first CreateWithOptions methods! 😄
Too bad that those two create signature methods did include CreateOptions originally.
When you get chance, can you remove the links to the RFC and JIRA from the PR description? I think my team has a preference for not including internal links in our open source projects 🤔
Oh, good to know! I've updated the PR description, @uturunku1 😊 |
ac73e98
to
24dedc5
Compare
Reminder to the contributor that merged this PR: if your changes have added important functionality or fixed a relevant bug, open a follow-up PR to update CHANGELOG.md with a note on your changes. |
Description
Adds
ExpiredAt
to Organization, Team, and User tokens and updates the accompanying tests. This is part of a larger change which adds a time-to-live to API authentication tokens.Testing plan
go-tfe
within the TFE provider.Output from tests
team_token_integration_test.go
results:organization_token_integration_test.go
results:user_token_integration_test.go
results: