Add filtering option to list workspaces of a particular project #671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hs26gill
force-pushed
the
hs26gill/TF-5351-add-filter-by-project-id-for-listing-workspaces
branch
from
a8272c4 to
3e8876c
Compare
hs26gill
force-pushed
the
hs26gill/TF-5351-add-filter-by-project-id-for-listing-workspaces
branch
from
3e8876c to
b30078d
Compare
nfagerlund
requested changes
Mar 30, 2023
hs26gill
force-pushed
the
hs26gill/TF-5351-add-filter-by-project-id-for-listing-workspaces
branch
from
27120cb to
1b01657
Compare
nfagerlund
reviewed
Mar 30, 2023
nfagerlund
previously approved these changes
Mar 30, 2023
One of these tests was flaking on this PR, probably because it was tacitly expecting that fewer than 20 workspaces ever exist at once on the CI TFC instance. The more tests we add that create temporary workspaces (like the ones in this PR), the more likely that test was to flake. Testing shared global state is always nasty and error-prone, but this commit adjusts a couple tests to make less precise assertions that hopefully still test the behavior of interest.
barrettclark
approved these changes
Mar 31, 2023
hs26gill
deleted the
hs26gill/TF-5351-add-filter-by-project-id-for-listing-workspaces
branch
|
Reminder to the contributor that merged this PR: if your changes have added important functionality or fixed a relevant bug, open a follow-up PR to update CHANGELOG.md with a note on your changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This add the support for users to list all the workspaces associated to a particular project in an organization by providing project_id filter option. API docs: https://developer.hashicorp.com/terraform/cloud-docs/api-docs/workspaces#list-workspaces
Testing plan
Integration tests have been added to cover this. You can run them using the below command:
External links