Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Manage Membership to team organization access #652

Merged
merged 1 commit into from
Mar 21, 2023

Conversation

JarrettSpiker
Copy link
Contributor

@JarrettSpiker JarrettSpiker commented Feb 15, 2023

Description

Add Manage Membership to team organization access

Testing plan

  1. Teams should be created with manageMembership as false by default
  2. ManageMembership is read for teams
  3. ManageMembership should be updatable through OrganizationAccessOptions

External links

Output from tests

❯ go test -run TestTeams -v
=== RUN   TestTeamsList
=== RUN   TestTeamsList/without_list_options
    team_integration_test.go:37: paging not supported yet in API
=== RUN   TestTeamsList/with_list_options
    team_integration_test.go:43: paging not supported yet in API
=== RUN   TestTeamsList/without_a_valid_organization
--- PASS: TestTeamsList (4.04s)
    --- SKIP: TestTeamsList/without_list_options (0.36s)
    --- SKIP: TestTeamsList/with_list_options (0.00s)
    --- PASS: TestTeamsList/without_a_valid_organization (0.00s)
=== RUN   TestTeamsCreate
=== RUN   TestTeamsCreate/with_valid_options
=== RUN   TestTeamsCreate/with_sso-team-id
=== RUN   TestTeamsCreate/when_options_is_missing_name
=== RUN   TestTeamsCreate/when_options_has_an_invalid_organization
--- PASS: TestTeamsCreate (2.38s)
    --- PASS: TestTeamsCreate/with_valid_options (0.41s)
    --- PASS: TestTeamsCreate/with_sso-team-id (0.18s)
    --- PASS: TestTeamsCreate/when_options_is_missing_name (0.00s)
    --- PASS: TestTeamsCreate/when_options_has_an_invalid_organization (0.00s)
=== RUN   TestTeamsRead
=== RUN   TestTeamsRead/when_the_team_exists
=== RUN   TestTeamsRead/when_the_team_exists/visibility_is_returned
=== RUN   TestTeamsRead/when_the_team_exists/permissions_are_properly_decoded
=== RUN   TestTeamsRead/when_the_team_exists/organization_access_is_properly_decoded
=== RUN   TestTeamsRead/when_the_team_exists/SSO_team_id_is_returned
=== RUN   TestTeamsRead/when_the_team_does_not_exist
=== RUN   TestTeamsRead/without_a_valid_team_ID
--- PASS: TestTeamsRead (2.35s)
    --- PASS: TestTeamsRead/when_the_team_exists (0.15s)
        --- PASS: TestTeamsRead/when_the_team_exists/visibility_is_returned (0.00s)
        --- PASS: TestTeamsRead/when_the_team_exists/permissions_are_properly_decoded (0.00s)
        --- PASS: TestTeamsRead/when_the_team_exists/organization_access_is_properly_decoded (0.00s)
        --- PASS: TestTeamsRead/when_the_team_exists/SSO_team_id_is_returned (0.00s)
    --- PASS: TestTeamsRead/when_the_team_does_not_exist (0.19s)
    --- PASS: TestTeamsRead/without_a_valid_team_ID (0.00s)
=== RUN   TestTeamsUpdate
=== RUN   TestTeamsUpdate/with_valid_options
=== RUN   TestTeamsUpdate/when_the_team_does_not_exist
=== RUN   TestTeamsUpdate/without_a_valid_team_ID
--- PASS: TestTeamsUpdate (2.06s)
    --- PASS: TestTeamsUpdate/with_valid_options (0.35s)
    --- PASS: TestTeamsUpdate/when_the_team_does_not_exist (0.11s)
    --- PASS: TestTeamsUpdate/without_a_valid_team_ID (0.00s)
=== RUN   TestTeamsDelete
=== RUN   TestTeamsDelete/with_valid_options
=== RUN   TestTeamsDelete/without_valid_team_ID
--- PASS: TestTeamsDelete (1.77s)
    --- PASS: TestTeamsDelete/with_valid_options (0.28s)
    --- PASS: TestTeamsDelete/without_valid_team_ID (0.00s)
=== RUN   TestTeamsUpdateRunTasks
    helper_test.go:2334: Skipping test related to a Terraform Cloud beta feature. Set ENABLE_BETA=1 to run.
--- SKIP: TestTeamsUpdateRunTasks (0.00s)
=== RUN   TestTeamsUpdateManageProjects
=== RUN   TestTeamsUpdateManageProjects/with_valid_options
--- PASS: TestTeamsUpdateManageProjects (2.01s)
    --- PASS: TestTeamsUpdateManageProjects/with_valid_options (0.33s)
=== RUN   TestTeamsUpdateManageManageMembership
--- PASS: TestTeamsUpdateManageManageMembership (2.18s)
PASS
ok  	github.com/hashicorp/go-tfe	16.923s

@JarrettSpiker JarrettSpiker requested a review from a team as a code owner February 15, 2023 17:27
@JarrettSpiker JarrettSpiker marked this pull request as draft February 15, 2023 17:27
JarrettSpiker added a commit that referenced this pull request Feb 15, 2023
JarrettSpiker added a commit that referenced this pull request Mar 14, 2023
@JarrettSpiker JarrettSpiker force-pushed the jspiker/manage-membership-permission branch from 3b96d9b to 0947366 Compare March 14, 2023 14:17
@JarrettSpiker JarrettSpiker force-pushed the jspiker/manage-membership-permission branch from 0947366 to d72904a Compare March 14, 2023 14:28
@JarrettSpiker JarrettSpiker marked this pull request as ready for review March 14, 2023 14:58
Copy link
Contributor

@laurenolivia laurenolivia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your patience ✅

@JarrettSpiker JarrettSpiker merged commit eff1681 into main Mar 21, 2023
@JarrettSpiker JarrettSpiker deleted the jspiker/manage-membership-permission branch March 21, 2023 20:42
@github-actions
Copy link

Reminder to the contributor that merged this PR: if your changes have added important functionality or fixed a relevant bug, open a follow-up PR to update CHANGELOG.md with a note on your changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants