Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update team project access to include additional project roles #642

Merged
merged 1 commit into from
Mar 17, 2023

Conversation

joekarl
Copy link

@joekarl joekarl commented Jan 26, 2023

Description

Updates the available team project access to include upcoming additional project access levels supported by the TFC API.
Should not be merged until those API changes are available.

API Docs: https://developer.hashicorp.com/terraform/cloud-docs/api-docs/project-team-access#project-team-access-levels

Product Docs: https://developer.hashicorp.com/terraform/cloud-docs/users-teams-organizations/permissions#project-permissions

Tests:

go test -run TestTeamProjectAccessesAdd -v ./...

@joekarl joekarl self-assigned this Jan 26, 2023
@joekarl joekarl requested a review from a team as a code owner January 26, 2023 18:03
sebasslash
sebasslash previously approved these changes Jan 26, 2023
Copy link
Contributor

@sebasslash sebasslash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Hold off on merging until API changes are released.

@annawinkler
Copy link
Contributor

Added the DO NOT MERGE label until I can clarify when the API changes will be released.

@joekarl joekarl force-pushed the kirch/additional_project_access_roles branch 2 times, most recently from 694d074 to e08c787 Compare February 14, 2023 20:44
@joekarl joekarl force-pushed the kirch/additional_project_access_roles branch from e08c787 to ae51e5c Compare March 1, 2023 16:30
@jbonhag jbonhag force-pushed the kirch/additional_project_access_roles branch from ae51e5c to d7652bd Compare March 15, 2023 21:17
@jbonhag jbonhag self-assigned this Mar 15, 2023
@jbonhag
Copy link
Contributor

jbonhag commented Mar 15, 2023

@sebasslash @annawinkler The new roles have been released to Terraform Cloud and docs changes are out. Pending CI, we should be good to merge; could you please review again when you get a chance? Thanks!

@jbonhag jbonhag requested a review from sebasslash March 16, 2023 20:17
@brandonc brandonc merged commit 76b2aee into main Mar 17, 2023
@brandonc brandonc deleted the kirch/additional_project_access_roles branch March 17, 2023 15:33
@github-actions
Copy link

Reminder to the contributor that merged this PR: if your changes have added important functionality or fixed a relevant bug, open a follow-up PR to update CHANGELOG.md with a note on your changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants