add sort and filter to admin/workspaces#list-all-workspaces #641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurenolivia
force-pushed
the
laurenolivia/admin-list-options
branch
2 times, most recently
from
453afa8 to
b29ee76
Compare
laurenolivia
force-pushed
the
laurenolivia/admin-list-options
branch
from
d4b068c to
e8d58eb
Compare
laurenolivia
commented
Feb 9, 2023
laurenolivia
force-pushed
the
laurenolivia/admin-list-options
branch
from
e8d58eb to
6ebe908
Compare
brandonc
previously approved these changes
Feb 14, 2023
sebasslash
previously approved these changes
Feb 14, 2023
laurenolivia
force-pushed
the
laurenolivia/admin-list-options
branch
from
8c908b8 to
11c3743
Compare
brandonc
approved these changes
Feb 14, 2023
nfagerlund
approved these changes
Feb 14, 2023
|
|
||
| require.NoError(t, err) | ||
| require.NotEmpty(t, wl.Items) | ||
| assert.Equal(t, wl.Items[0].CurrentRun.Status, RunApplied) |
There was a problem hiding this comment.
Oh, now that I think this through an extra step, this is fine and doesn't need to be changed to an assert.Contains with our run. I got all turned around! But because the filter is limiting runs to the RunApplied status, the first run definitely has to be in status RunApplied, even if it's not the run we created. 👍🏼
|
Reminder to the contributor that merged this PR: if your changes have added important functionality or fixed a relevant bug, open a follow-up PR to update CHANGELOG.md with a note on your changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Admin Workspace API includes a sort and filter feature. There was a request to expose this in go-tfe.
Testing plan
nameorcurrent-run.created-atrun statusExternal links
API Docs
Output from tests
Including output from tests may require access to a TFE instance. Ignore this section if you have no environment to test against.