Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ReadWorkspaces and ReadProjects to Orgs #614

Merged

Conversation

juliannatetreault
Copy link
Contributor

@juliannatetreault juliannatetreault commented Dec 13, 2022

Description

Adds ReadWorkspaces and ReadProjects permissions to Organizations in team.go and updates the accompanying test, team_integration_test.go. These are all part of a larger change which gives read access at an organization level.

This change is in draft as we complete the feature and prepare for its release.

Testing plan

  1. Verify that you can set the properties by using go-tfe within the TFE provider (caveat: this isn't doable yet!)
  2. Verify that all tests still pass.

External links

Output from tests

Including output from tests may require access to a TFE instance. Ignore this section if you have no environment to test against.

=== RUN   TestTeam_Unmarshal
--- PASS: TestTeam_Unmarshal (0.00s)
PASS

Process finished with the exit code 0

=== RUN   TestTeamCreateOptions_Marshal
--- PASS: TestTeamCreateOptions_Marshal (0.00s)
PASS

Process finished with the exit code 0

@hashicorp-cla
Copy link

hashicorp-cla commented Dec 13, 2022

CLA assistant check
All committers have signed the CLA.

@juliannatetreault juliannatetreault force-pushed the juliannatetreault/add-read-access-org-permission-set branch from 70111d2 to 34b3a11 Compare December 15, 2022 19:39
@SwiftEngineer SwiftEngineer marked this pull request as ready for review January 25, 2023 02:10
@SwiftEngineer SwiftEngineer requested a review from a team as a code owner January 25, 2023 02:10
Copy link
Member

@nfagerlund nfagerlund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! I ran the code in my test project just to make sure, and it does what it's meant to do.

I'm marking as request changes because of the time-traveling changelog line (which now that I think on it is likely just due to the merge from upstream). Once that's sorted out, I'll be 👍🏼 to merge!

@juliannatetreault juliannatetreault force-pushed the juliannatetreault/add-read-access-org-permission-set branch from fe7f72c to 298fda7 Compare February 2, 2023 18:02
Copy link
Member

@nfagerlund nfagerlund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, this WOULD be good to go, except that our CI is broken at the moment. Team's looking into it and I'll kick the jobs when it's working again.

@juliannatetreault
Copy link
Contributor Author

Well, this WOULD be good to go, except that our CI is broken at the moment. Team's looking into it and I'll kick the jobs when it's working again.

No worries at all! Thank you so much for the update and reviews 🌟

@annawinkler annawinkler merged commit 40e7f9e into main Feb 7, 2023
@annawinkler annawinkler deleted the juliannatetreault/add-read-access-org-permission-set branch February 7, 2023 22:19
@github-actions
Copy link

github-actions bot commented Feb 7, 2023

Reminder to the contributor that merged this PR: if your changes have added important functionality or fixed a relevant bug, open a follow-up PR to update CHANGELOG.md with a note on your changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants