-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ReadWorkspaces and ReadProjects to Orgs #614
Add ReadWorkspaces and ReadProjects to Orgs #614
Conversation
70111d2
to
34b3a11
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good! I ran the code in my test project just to make sure, and it does what it's meant to do.
I'm marking as request changes because of the time-traveling changelog line (which now that I think on it is likely just due to the merge from upstream). Once that's sorted out, I'll be 👍🏼 to merge!
fe7f72c
to
298fda7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, this WOULD be good to go, except that our CI is broken at the moment. Team's looking into it and I'll kick the jobs when it's working again.
No worries at all! Thank you so much for the update and reviews 🌟 |
Reminder to the contributor that merged this PR: if your changes have added important functionality or fixed a relevant bug, open a follow-up PR to update CHANGELOG.md with a note on your changes. |
Description
Adds
ReadWorkspaces
andReadProjects
permissions to Organizations inteam.go
and updates the accompanying test,team_integration_test.go
. These are all part of a larger change which gives read access at an organization level.This change is in draft as we complete the feature and prepare for its release.
Testing plan
go-tfe
within the TFE provider (caveat: this isn't doable yet!)External links
Output from tests
Including output from tests may require access to a TFE instance. Ignore this section if you have no environment to test against.