-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CRUD support for Projects API #564
Conversation
0ebc00a
to
c52575e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done -- a couple of nitpick/naming-related things but it seems to be in good shape!
87fd140
to
64d7011
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moving in the right direction 🕺 Some comments down below 😄
64d7011
to
22719f1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All this looks great. My one bit of blocking feedback is that all the new go docs need to be clearly labeled as beta, and the CHANGELOG should make it clear that the features are not generally available and subject to change.
Ex:
type Projects interface
// List all projects in the given organization
// **Note: This field is still in BETA and subject to change.**
List(ctx...)
...
}
See the Adding API Changes that are Not Generally Available section of CONTRIBUTING.md for details.
Reminder to the contributor that merged this PR: if your changes have added important functionality or fixed a relevant bug, open a follow-up PR to update CHANGELOG.md with a note on your changes. |
Description
A new
Projects
API is added to allow users to organize and centrally manage their workspaces at scale.Testing plan
To run the integration test: