(TER-183) Add Description for Run Tasks #447
Conversation
glennsarti
force-pushed
the
gs/add-task-description
branch
from
2635518 to
2ec54a8
Compare
glennsarti
changed the title
glennsarti
force-pushed
the
gs/add-task-description
branch
2 times, most recently
from
c748067 to
9f904b8
Compare
helper_test.go
Outdated
| t.Errorf("Error destroying workspace! WARNING: Dangling resources\n"+ | ||
| "may exist! The full error is shown below.\n\n"+ | ||
| "Workspace: %s\nError: %s", w.Name, err) | ||
| if errors.Is(err, ErrResourceNotFound) { |
There was a problem hiding this comment.
Could you explain this change?
There was a problem hiding this comment.
So one of the integration tests was failing (checking for removed workspace). It was due to the test cleanup failing; errored trying to remove a workspace that was already removed.
So it begged the question; If you try to cleanup a workspace that's already been cleaned up, should it throw an err?
However this all moot because I've just noticed the test could be setup in a way I didn't have to do this change. But the question is still valid, and perhaps it should be in a different PR.
There was a problem hiding this comment.
@glennsarti That's a good question re what to do with a workspace if it's already been cleaned up. I've opened an internal issue for the team to discuss this and update our contributing docs with some guidance.
There was a problem hiding this comment.
This is looking good! ⭐ I think we might want to move the CircleCI environment variable to CircleCI (and not in the config.yml) for consistency with the other environment variables used for testing. I had a few other questions that I have left as comments in the PR.
|
Thanks @annawinkler , I also got side tracked while doing this PR due to unrelated CI failures so I didn't come back to it :-) |
glennsarti
force-pushed
the
gs/add-task-description
branch
3 times, most recently
from
f1fd87d to
3229f93
Compare
|
@annawinkler Can I get a +1 on this so I can merge. |
Previously Run Tasks was marked as beta in go-tfe. However Run Tasks is now Generally Available. This commit updates go-tfe to mark Run Tasks as not Beta.
Run Tasks now have an optional description field. This commit updates the RunTask API endpoints to include the description where applicable (Create/Read/Update).
glennsarti
force-pushed
the
gs/add-task-description
branch
from
3229f93 to
0ad3cbc
Compare
|
Ping @annawinkler |
| @@ -73,14 +73,14 @@ const ( | |||
| type RunTaskListOptions struct { | |||
| ListOptions | |||
| // Optional: A list of relations to include with a run task. See available resources: | |||
| // https://www.terraform.io/cloud-docs/api-docs/run-tasks#list-run-tasks | |||
| // https://www.terraform.io/cloud-docs/api-docs/run-tasks/run-tasks#list-run-tasks | |||
|
Thanks @Uk1288 |
glennsarti
dismissed
annawinkler’s stale review
No longer true and addressed issues raised.
|
Reminder to the contributor that merged this PR: if your changes have added important functionality or fixed a relevant bug, open a follow-up PR to update CHANGELOG.md with a note on your changes. |
Description
Previously Run Tasks was marked as beta in go-tfe. However Run Tasks is now
Generally Available. This commit updates go-tfe to mark Run Tasks as not
Beta.
Run Tasks now have an optional description field. This commit updates
the RunTask API endpoints to include the description where applicable
(Create/Read/Update).
Testing plan
N/A Integration tests updated
External links
Output from tests
N/A Circle CI output