-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add exclude tags to workspace list options #438
add exclude tags to workspace list options #438
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🌟 Thanks for opening this PR! It looks like you need to complete the contributor agreement for this repo. I took a quick look at the test failures, and one might be failing because of this change. Maybe take a look?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests are failing since it's not available in tflocal yet. Code changes look good to me 🔥
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 once API & docs are merged
8a4ff98
to
5ff2232
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woohoo! 🔥
Reminder to the contributor that merged this PR: if your changes have added important functionality or fixed a relevant bug, open a follow-up PR to update CHANGELOG.md with a note on your changes. |
Description
Currently the list of Workspaces within an Organization can be filtered with
Tags
string to include. This PR adds the ability to exclude workspaces by tags using theExcludeTags
option.For example, given
workspace1
with tagone
andworkspace2
with tagtwo
, invokingshould only return
workspace1
.Testing plan
External links
Output from tests
Including output from tests may require access to a TFE instance. Ignore this section if you have no environment to test against.