Adds StateVersionOutputs ReadCurrent #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebasslash
reviewed
Mar 30, 2022
uturunku1
approved these changes
Apr 1, 2022
| @@ -16,6 +16,7 @@ var _ StateVersionOutputs = (*stateVersionOutputs)(nil) | |||
| // TFE API docs: https://www.terraform.io/docs/cloud/api/state-version-outputs.html | |||
| type StateVersionOutputs interface { | |||
| Read(ctx context.Context, outputID string) (*StateVersionOutput, error) | |||
| ReadCurrent(ctx context.Context, workspaceID string) (*StateVersionOutputsList, error) | |||
There was a problem hiding this comment.
I see we have this precedence for ReadCurrent and ReadCurrentwithOptions: https://github.com/hashicorp/go-tfe/blob/main/state_version.go#L33-L36 But if this endpoint won't be adding options in the near future, then we are good.
| // Read a State Version Output | ||
| func (s *stateVersionOutputs) Read(ctx context.Context, outputID string) (*StateVersionOutput, error) { | ||
| if !validStringID(&outputID) { | ||
| return nil, ErrInvalidRunID | ||
| return nil, ErrInvalidOutputID |
There was a problem hiding this comment.
geeze, were we returning the incorrect error message all this time?
| @@ -12,7 +12,7 @@ import ( | |||
| "github.com/stretchr/testify/require" | |||
| ) | |||
|
|
|||
| const waitForStateVersionOutputs = 700 * time.Millisecond | |||
| const waitForStateVersionOutputs = 1000 * time.Millisecond | |||
There was a problem hiding this comment.
why 1000 instead of 700?
There was a problem hiding this comment.
My tests didn't pass locally with the old timing.
|
Reminder to the contributor that merged this PR: if your changes have added important functionality or fixed a relevant bug, open a follow-up PR to update CHANGELOG.md with a note on your changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I'd like to support the new current-state-version-outputs endpoint to unblock a bug fix within terraform
External links
Output from tests (HashiCorp employees only)