Unmarshal link members; Add Upload() for registry module version slugs #221
Conversation
Includes support for unmarshaling link members
Similar to configuration versions, with the slight modification that I don't believe client users should care about piping the correct upload link to Upload(), or it's little more than syntatic sugar for a simple PUT request. With this, just provide a newly created RMV to Upload() with a path to your module files and away you go.
|
|
||
| body := bytes.NewBuffer(nil) | ||
|
|
||
| _, err = slug.Pack(path, body, true) |
There was a problem hiding this comment.
I think slug.Pack here will respect the settings in a .terraformignore file if the user has one, which seems like it could possibly lead to this having confusing behavior if that's something the user wasn't expecting.
On the other hand, since this is a Terraform module, maybe that's actually the more intuitive behavior! Either way, I wanted to call it out in case it's something you hadn't considered.
There was a problem hiding this comment.
Ahh good call out! No, I hadn't thought of that at all.
I'm not sure if it should respect the ignore file or not (my gut reaction is 'it should' but honestly I dunno), but regardless in the name of consistency I'll leave it as is - this is identical to how configuration versions currently work.
Description
With hashicorp/jsonapi#10, we're now able to do something often-requested for this client: Fetch upload URLs for policy sets and registry modules (which differ from configuration versions in that they provide upload links in the
linksmember of a response, not a standard attribute).Here I've included registry module uploads; policy set versions can be handled separately.
Closes #159
Output from tests