Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Admin General Settings attr default-remote-state-access #205

Merged
merged 2 commits into from
Apr 19, 2021
Merged

Add Admin General Settings attr default-remote-state-access #205

merged 2 commits into from
Apr 19, 2021

Conversation

omarismail
Copy link
Contributor

Description

This PR adds the attribute to the Admin General Settings for default-remote-state-access.

See API Docs

Note: this was previously opened/merged then reverted. Will merge at a later day.

@omarismail omarismail requested a review from a team April 13, 2021 17:17
chrisarcand
chrisarcand approved these changes Apr 16, 2021
View reviewed changes
Copy link
Member

@chrisarcand chrisarcand left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks ready to roll, pending the feature release! ✅

@omarismail omarismail merged commit a111fba into master Apr 19, 2021
@omarismail omarismail deleted the omarismail/add-general-settings branch April 19, 2021 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisarcand chrisarcand chrisarcand approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@omarismail @chrisarcand