Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Manage Policy Overrides permission #198

Merged
merged 2 commits into from
Apr 13, 2021

Conversation

cam-stitt
Copy link
Member

@cam-stitt cam-stitt commented Mar 25, 2021

Description

A new permission, Manage Policy Overrides is being added to the Organization Access for teams. This PR adds the field as required.

External links

Output from tests

$ go test -run TestTeams -v ./...
=== RUN   TestTeamsList
=== RUN   TestTeamsList/without_list_options
    team_test.go:29: paging not supported yet in API
=== RUN   TestTeamsList/with_list_options
    team_test.go:35: paging not supported yet in API
=== RUN   TestTeamsList/without_a_valid_organization
--- PASS: TestTeamsList (6.57s)
    --- SKIP: TestTeamsList/without_list_options (0.68s)
    --- SKIP: TestTeamsList/with_list_options (0.00s)
    --- PASS: TestTeamsList/without_a_valid_organization (0.00s)
=== RUN   TestTeamsCreate
=== RUN   TestTeamsCreate/with_valid_options
=== RUN   TestTeamsCreate/when_options_is_missing_name
=== RUN   TestTeamsCreate/when_options_has_an_invalid_organization
--- PASS: TestTeamsCreate (3.45s)
    --- PASS: TestTeamsCreate/with_valid_options (1.08s)
    --- PASS: TestTeamsCreate/when_options_is_missing_name (0.00s)
    --- PASS: TestTeamsCreate/when_options_has_an_invalid_organization (0.00s)
=== RUN   TestTeamsRead
=== RUN   TestTeamsRead/when_the_team_exists
=== RUN   TestTeamsRead/when_the_team_exists/visibility_is_returned
=== RUN   TestTeamsRead/when_the_team_exists/permissions_are_properly_decoded
=== RUN   TestTeamsRead/when_the_team_exists/organization_access_is_properly_decoded
=== RUN   TestTeamsRead/when_the_team_does_not_exist
=== RUN   TestTeamsRead/without_a_valid_team_ID
--- PASS: TestTeamsRead (5.01s)
    --- PASS: TestTeamsRead/when_the_team_exists (0.53s)
        --- PASS: TestTeamsRead/when_the_team_exists/visibility_is_returned (0.00s)
        --- PASS: TestTeamsRead/when_the_team_exists/permissions_are_properly_decoded (0.00s)
        --- PASS: TestTeamsRead/when_the_team_exists/organization_access_is_properly_decoded (0.00s)
    --- PASS: TestTeamsRead/when_the_team_does_not_exist (0.57s)
    --- PASS: TestTeamsRead/without_a_valid_team_ID (0.00s)
=== RUN   TestTeamsUpdate
=== RUN   TestTeamsUpdate/with_valid_options
=== RUN   TestTeamsUpdate/when_the_team_does_not_exist
=== RUN   TestTeamsUpdate/without_a_valid_team_ID
--- PASS: TestTeamsUpdate (5.66s)
    --- PASS: TestTeamsUpdate/with_valid_options (1.21s)
    --- PASS: TestTeamsUpdate/when_the_team_does_not_exist (0.51s)
    --- PASS: TestTeamsUpdate/without_a_valid_team_ID (0.00s)
=== RUN   TestTeamsDelete
=== RUN   TestTeamsDelete/with_valid_options
=== RUN   TestTeamsDelete/without_valid_team_ID
--- PASS: TestTeamsDelete (4.68s)
    --- PASS: TestTeamsDelete/with_valid_options (1.06s)
    --- PASS: TestTeamsDelete/without_valid_team_ID (0.00s)
PASS
ok  	github.com/hashicorp/go-tfe	25.851s

@cam-stitt cam-stitt force-pushed the cam-stitt/override-policies-permission branch from b9b773e to 8c37a3a Compare April 13, 2021 03:39
@cam-stitt cam-stitt marked this pull request as ready for review April 13, 2021 23:15
@cam-stitt cam-stitt requested a review from a team April 13, 2021 23:15
Copy link
Member

@chrisarcand chrisarcand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@chrisarcand chrisarcand merged commit 525c771 into master Apr 13, 2021
@chrisarcand chrisarcand deleted the cam-stitt/override-policies-permission branch April 13, 2021 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants