Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TF-23543] Patch Terraform Tool Version with Archs #1047

Merged
merged 5 commits into from
Feb 3, 2025

Conversation

kelsi-hoyle
Copy link
Contributor

@kelsi-hoyle kelsi-hoyle commented Jan 29, 2025

Description

  • Adds ToolVersionArchitecture to AdminTerraformVersionUpdateOptions and AdminTerraformVersion
    • Enables updating Tool Versions with an Arch or sha/url
    • Archs field is now available on the response

Output from tests

Including output from tests may require access to a TFE instance. Ignore this section if you have no environment to test against.

$ envchain test go test -run TestAdminTerraformVersions_List
PASS
ok      github.com/hashicorp/go-tfe     1.865s

$ envchain test go test -run TestAdminTerraformVersions_CreateDelete                               
PASS
ok      github.com/hashicorp/go-tfe     1.657s

$ envchain test go test -run TestAdminTerraformVersions_ReadUpdate  
PASS
ok      github.com/hashicorp/go-tfe     1.761s

...

Copy link

hashicorp-cla-app bot commented Jan 29, 2025

CLA assistant check
All committers have signed the CLA.

@datadog-terraform-cloud-hashicorp
Copy link

datadog-terraform-cloud-hashicorp bot commented Jan 29, 2025

Datadog Report

Branch report: kelsi-hoyle/TF-23543/patch-archs
Commit report: d84ad99
Test service: hashicorp/go-tfe

✅ 0 Failed, 1421 Passed, 164 Skipped, 22m 25.82s Total Time
➡️ Test Sessions change in coverage: 1 no change

@kelsi-hoyle kelsi-hoyle force-pushed the kelsi-hoyle/TF-23543/patch-archs branch 2 times, most recently from 9b57a61 to ff33a69 Compare January 29, 2025 22:40
@kelsi-hoyle kelsi-hoyle marked this pull request as ready for review January 29, 2025 22:47
@kelsi-hoyle kelsi-hoyle requested a review from a team as a code owner January 29, 2025 22:47
@kelsi-hoyle kelsi-hoyle force-pushed the kelsi-hoyle/TF-23543/patch-archs branch from ee9c2de to 7c45d69 Compare January 29, 2025 23:00
natalie-todd
natalie-todd previously approved these changes Jan 30, 2025
Copy link
Contributor

@sebasslash sebasslash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎸 🔥

@kelsi-hoyle kelsi-hoyle force-pushed the kelsi-hoyle/TF-23543/patch-archs branch from 51bdacf to 4397429 Compare January 31, 2025 21:44
@kelsi-hoyle kelsi-hoyle merged commit 6361be9 into main Feb 3, 2025
7 checks passed
@kelsi-hoyle kelsi-hoyle deleted the kelsi-hoyle/TF-23543/patch-archs branch February 3, 2025 15:36
Copy link

github-actions bot commented Feb 3, 2025

Reminder to the contributor that merged this PR: if your changes have added important functionality or fixed a relevant bug, open a follow-up PR to update CHANGELOG.md with a note on your changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants