Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add variable sets permission to team project #1021

Merged

Conversation

netramali
Copy link
Contributor

@netramali netramali commented Dec 16, 2024

Description

We added a new custom permission type variable sets to team projects in atlas and hence the same needs to be done in go-tfe.

https://github.com/hashicorp/atlas/pull/21937

Testing plan

The integration tests pass.

External links

Output from tests

Including output from tests may require access to a TFE instance. Ignore this section if you have no environment to test against.

Screenshot 2025-01-14 at 11 28 59 AM Screenshot 2025-01-14 at 11 29 26 AM

@datadog-terraform-cloud-hashicorp
Copy link

datadog-terraform-cloud-hashicorp bot commented Jan 10, 2025

Datadog Report

Branch report: netramali/TF-22972-add-project-varset-permission-to-team-project
Commit report: ec87d10
Test service: hashicorp/go-tfe

✅ 0 Failed, 1421 Passed, 162 Skipped, 21m 9.42s Total Time
🔻 Test Sessions change in coverage: 1 decreased (-0.1%)

🔻 Code Coverage Decreases vs Default Branch (1)

  • datadog-ci junit upload 59.3% (-0.1%) - Details

mkam
mkam previously approved these changes Jan 10, 2025
@netramali netramali marked this pull request as ready for review January 10, 2025 20:39
@netramali netramali requested a review from a team as a code owner January 10, 2025 20:39
@uturunku1 uturunku1 self-requested a review January 14, 2025 17:18
@netramali netramali merged commit 4dfce8f into main Jan 14, 2025
7 checks passed
@netramali netramali deleted the netramali/TF-22972-add-project-varset-permission-to-team-project branch January 14, 2025 17:22
Copy link

Reminder to the contributor that merged this PR: if your changes have added important functionality or fixed a relevant bug, open a follow-up PR to update CHANGELOG.md with a note on your changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants