Merge pull request #789 from hashicorp/hashimoon/TF-7737-fix-attribute

hashimoon · web-flow · commit 87a455e5cc27 · 2023-10-10T16:39:09.000-07:00
[TF-7737] Fix incorrect attribute type for `RegistryModule.VCSRepo.Tags`
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,9 @@
 <!-- Add CHANGELOG entry to this section for any PR awaiting the next release -->
 <!-- Please also include if this is a Bug Fix, Enhancement, or Feature -->
 
+## Bug Fixes
+* Fix incorrect attribute type for `RegistryModule.VCSRepo.Tags` by @hashimoon [#789](https://github.com/hashicorp/go-tfe/pull/789)
+
 # v.1.35.0
 ## Features
 * Added BETA support for private module registry tests by @hashimoon [#781](https://github.com/hashicorp/go-tfe/pull/781)
diff --git a/registry_module.go b/registry_module.go
@@ -298,7 +298,7 @@ type RegistryModuleVCSRepoUpdateOptions struct {
 	// When a value for Tags is provided, the Branch field is removed on the server
 	// **Note: This field is still in BETA and subject to change.**
 	Branch *string `json:"branch,omitempty"`
-	Tags   *string `json:"tags,omitempty"`
+	Tags   *bool   `json:"tags,omitempty"`
 }
 
 // List all the registory modules within an organization.
diff --git a/registry_module_integration_test.go b/registry_module_integration_test.go
@@ -383,7 +383,7 @@ func TestRegistryModuleUpdateWithVCSConnection(t *testing.T) {
 
 		options = RegistryModuleUpdateOptions{
 			VCSRepo: &RegistryModuleVCSRepoUpdateOptions{
-				Tags: String("1.0.0"),
+				Tags: Bool(true),
 			},
 		}
 		rm, err = client.RegistryModules.Update(ctx, RegistryModuleID{

Original file line number	Diff line number	Diff line change
`@@ -298,7 +298,7 @@ type RegistryModuleVCSRepoUpdateOptions struct {`
`298`	`298`	`// When a value for Tags is provided, the Branch field is removed on the server`
`299`	`299`	`// Note: This field is still in BETA and subject to change.`
`300`	`300`	Branch *string `json:"branch,omitempty"`
`301`		- Tags *string `json:"tags,omitempty"`
	`301`	+ Tags *bool `json:"tags,omitempty"`
`302`	`302`	`}`
`303`	`303`
`304`	`304`	`// List all the registory modules within an organization.`
Original file line number	Diff line number	Diff line change
`@@ -383,7 +383,7 @@ func TestRegistryModuleUpdateWithVCSConnection(t *testing.T) {`
`383`	`383`
`384`	`384`	`options = RegistryModuleUpdateOptions{`
`385`	`385`	`VCSRepo: &RegistryModuleVCSRepoUpdateOptions{`
`386`		`- Tags: String("1.0.0"),`
	`386`	`+ Tags: Bool(true),`
`387`	`387`	`},`
`388`	`388`	`}`
`389`	`389`	`rm, err = client.RegistryModules.Update(ctx, RegistryModuleID{`