add ProtocolVersion to ReattachConfig #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A client connecting to a plugin process needs to know the resolved ProtocolVersion, so this PR adds that information to the returned reattach config. Prior to this, client.NegotiatedVersion() always returned 0.
kmoe
added a commit
to hashicorp/terraform-exec
that referenced
this pull request
May 25, 2021
As of go-plugin v1.4.1, the reattach config now contains protocol version information so that protocol version can be negotiated during reattach. Please see hashicorp/go-plugin#171.
kmoe
added a commit
to hashicorp/terraform-exec
that referenced
this pull request
May 27, 2021
As of go-plugin v1.4.1, the reattach config now contains protocol version information so that protocol version can be negotiated during reattach. Please see hashicorp/go-plugin#171.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the (already-determined)
ProtocolVersiontoReattachConfig. This information was not captured previously, so a caller connecting to a running process had no way of knowing whatProtocolVersionhad been negotiated:client.NegotiatedVersionwould always return0.