Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add AWS endpoint definition as an option #194

Merged
merged 1 commit into from
Jun 21, 2022
Merged

Add AWS endpoint definition as an option #194

merged 1 commit into from
Jun 21, 2022

Conversation

obeyler
Copy link
Contributor

@obeyler obeyler commented Apr 20, 2022

Fixes #107

inspired by Allow setting a endpointURL on AWS provider #108 PR

@hashicorp-cla
Copy link

hashicorp-cla commented Apr 20, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@obeyler
Copy link
Contributor Author

obeyler commented Apr 22, 2022 •
edited
Loading

@ishustava or @blake could you review this PR Thanks by advance

@obeyler
Copy link
Contributor Author

obeyler commented May 12, 2022

@dhiaayachi could you review this PR / approve it
Thanks by advance

This was referenced May 13, 2022
Closed
Closed
@Amier3
Copy link

Amier3 commented May 24, 2022

Hey @obeyler

Thanks for raising this PR. Since we didn't anticipate this PR being made, we'll have to discuss the change first and let you know our thoughts on the feature. We'll meet today to talk about it and hopefully get you some feedback this week.

@obeyler
Copy link
Contributor Author

obeyler commented May 24, 2022

Thanks by advance

@Amier3 Amier3 requested a review from acpana May 31, 2022 20:31
@acpana
Copy link

acpana commented Jun 7, 2022 •
edited
Loading

hey @obeyler thanks for opening this and for your patience with our response.

I'd say that overall the changes LGTM, especially given the feedback from 108.

I'm curious to hear more about your use case. Can you use the private_dns solution that is mentioned here: #108 (comment) in your case?

@obeyler
Copy link
Contributor Author

obeyler commented Jun 7, 2022 •
edited
Loading

hey @obeyler thanks for opening this and for your patience with our response.

I'd say that overall the changes LGTM, especially given the feedback from 108.

I'm curious to hear more about your use case. Can you use the private_dns solution that is mentioned here: #108 (comment) in your case?

Hi @acpana,
We can't use private dns in our case because we use simultaneously both aws and outscale endpoint. So on, we can t change the dns resolution to replace aws endpoint.

@obeyler
Copy link
Contributor Author

obeyler commented Jun 8, 2022

so on @acpana @Amier3 what is the next step ;-) ?

@obeyler
Copy link
Contributor Author

obeyler commented Jun 16, 2022

@acpana @Amier3 no news ?

@acpana acpana merged commit a413e13 into hashicorp:master Jun 21, 2022
@Amier3
Copy link

Amier3 commented Jun 21, 2022

Hey @obeyler

Sorry for the consistent delays, luckily we were able to get this merged so hopefully this fixes the issues you were having 😄 . go-discover is a really important package that's used by a lot of the different teams across Hashicorp, so we're always careful with any PR to make sure nothing breaks.

We were hoping to get a couple engineers to review this to be extra careful, but that ended up being too difficult to coordinate. Thank you again for the PR!

@obeyler
Copy link
Contributor Author

obeyler commented Jun 23, 2022

thanks !

acaloiaro pushed a commit to acaloiaro/go-discover that referenced this pull request Nov 24, 2022
@obeyler @acaloiaro
Add AWS endpoint definition as an option (hashicorp#194)
b21cbd5 
Signed-off-by: obeyler <[email protected]>
acaloiaro pushed a commit to acaloiaro/go-discover that referenced this pull request Nov 24, 2022
@obeyler @acaloiaro
Add AWS endpoint definition as an option (hashicorp#194)
c263bdb 
Signed-off-by: obeyler <[email protected]>
elprans pushed a commit to geldata/go-discover that referenced this pull request Dec 2, 2022
@obeyler @elprans
Add AWS endpoint definition as an option (hashicorp#194)
20d4832 
Signed-off-by: obeyler <[email protected]>
peczenyj pushed a commit to peczenyj/go-discover that referenced this pull request Dec 21, 2023
@jeffwidman @peczenyj
parent 738cb31
a49c317 
author Jeff Widman <[email protected]> 1621366525 -0700
committer Tiago Peczenyj <[email protected]> 1703171978 +0100

Update tencent version

Tencent pulled the previous tag of their API and switched to `v1`
starting here: https://github.com/TencentCloud/tencentcloud-sdk-go#%E9%80%9A%E8%BF%87go-get%E5%AE%89%E8%A3%85%E6%8E%A8%E8%8D%90

As a result, currently `go get -d` is complaining in downstream repos,
breaking Dependabot (among other things).

So this fixes that.

Fix hashicorp#172.

Update CI badge to CircleCI

The old badge was travis, and we have not used travis in some time.

update dependency

fix incompatibity issue hashicorp#183

Revert "fix incompatibity issue hashicorp#183"

This reverts commit 986207c.

Revert "update dependency"

This reverts commit bc42ce5.

update dependency github.com/denverdino/aliyungo

fix incompatibity issue hashicorp#183

go mod tidy

Add AWS SessionToken Support (hashicorp#189)

* add support for SessionToken in AWS credential resolver

* add AWS AssumeRole configuration to AWS tests

Fix "Config options" links

Apply suggestions from code review

Co-authored-by: Blake Covarrubias <[email protected]>

deps: bump Azure/go-autorest to remove transitive jwt-go dependency with known vulnerability (hashicorp#174)

update dependency github.com/denverdino/aliyungo

Add AWS SessionToken Support (hashicorp#189)

* add support for SessionToken in AWS credential resolver

* add AWS AssumeRole configuration to AWS tests

Fix "Config options" links

Apply suggestions from code review

Co-authored-by: Blake Covarrubias <[email protected]>

Add AWS endpoint definition as an option (hashicorp#194)

Signed-off-by: obeyler <[email protected]>

Feature/aws ecs support (hashicorp#197)

* Add service argument to aws provider, where service can be either ec2 or ecs (defaulting to ec2)
* Add optional ecs_cluster and ecs_family arguments

Update tencentcloud-sdk-go modules

Dependencies are available as individual go modules now.

[COMPLIANCE] Update MPL 2.0 LICENSE

Adding workflow .github/actions/acctest/action.yml
.github/actions/tf-install/action.yml
.github/workflows/acceptance.yml

SHA-pin all 3rd-party actions

Restrict workflow permissions

Add actionslint

Add dependabot

Add CODEOWNERS

Remove CircleCI configuration

Remove unused local actions

Update migration

enable scleway acceptance test

add success job

add success job

fix copy pasta

Result of tsccr-helper -pin-all-workflows .

Fix CVEs

Need at least go 1.16 for the golang.org/x/net fixes

Update github action to use go 1.16

Some dependencies needed 1.17

Set miekg/dns to 1.1.50

Result of tsccr-helper -log-level=info -pin-all-workflows .

Update README.md

Update README.md

Update README.md

Update README.md

update vendor github.com/denverdino/aliyungo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acpana acpana Awaiting requested review from acpana

Assignees

@acpana acpana

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow setting custom endpoint URL on the AWS provider
4 participants
@obeyler @hashicorp-cla @Amier3 @acpana