Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Base Layer to replace go-autorest #122

Merged
merged 57 commits into from
Jan 26, 2023
Merged

New Base Layer to replace go-autorest #122

merged 57 commits into from
Jan 26, 2023

Conversation

manicminer
Copy link
Contributor

@manicminer manicminer commented Aug 23, 2022

@manicminer manicminer added the enhancement New feature or request label Aug 23, 2022
@manicminer manicminer requested a review from a team as a code owner August 23, 2022 00:20
@github-actions github-actions bot added the release-once-merged The SDK should be released once this PR is merged label Sep 18, 2022
@github-actions github-actions bot removed the release-once-merged The SDK should be released once this PR is merged label Sep 18, 2022
@manicminer manicminer force-pushed the base-layer branch 11 times, most recently from c7e3fd9 to 36aff20 Compare September 18, 2022 06:18
@wuxu92
Copy link
Contributor

wuxu92 commented Oct 25, 2022

Is there a schedule for this PR release? so we can use the new base layer for Automation services, I am trying to fix the broken resources that exist in azurerm. both of them are because of the autorest bug and the service team's unwilling to fix the swagger 😫

- use native crypto types, avoid double decoding raw cert/key data
- rename CLientFederatedAuth to OIDCAuth
- test for OIDC authentication
- change some return types to pointers
- refactoring to support future signing algorithms
@tombuildsstuff
Copy link
Contributor

The Base Layer needs to account for an error being returned via a 200 OK too, see: hashicorp/terraform-provider-azurerm#19849 (comment)

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of comments inline but otherwise 👍 nice work

sdk/auth/github_oidc_authorizer.go Outdated Show resolved Hide resolved
sdk/auth/oidc_authorizer.go Outdated Show resolved Hide resolved
@manicminer manicminer merged commit ed3ba32 into main Jan 26, 2023
@manicminer manicminer deleted the base-layer branch January 26, 2023 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants