-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Base Layer to replace go-autorest #122
Conversation
f3a765e
to
6c3b9ea
Compare
c7e3fd9
to
36aff20
Compare
5c8033a
to
da80bcc
Compare
Is there a schedule for this PR release? so we can use the new base layer for Automation services, I am trying to fix the broken resources that exist in azurerm. both of them are because of the autorest bug and the service team's unwilling to fix the swagger 😫 |
da80bcc
to
f6a54c2
Compare
f6a54c2
to
3671e14
Compare
3671e14
to
c686b5f
Compare
5f67394
to
6f2b2d6
Compare
- use native crypto types, avoid double decoding raw cert/key data - rename CLientFederatedAuth to OIDCAuth - test for OIDC authentication - change some return types to pointers - refactoring to support future signing algorithms
… in the UserAgent
…ed for SharedKeyAuthentication This also involves changing the HTTP Request pipeline such that we build the token from the HTTP Request at Execution time rather than when the HTTP Request is first created.
This enables us to dynamically poll on either a LRO or a provisioningState field, if one is found
5fd4b54
to
f814228
Compare
The Base Layer needs to account for an error being returned via a 200 OK too, see: hashicorp/terraform-provider-azurerm#19849 (comment) |
… request when a response has no Content-Type header
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a couple of comments inline but otherwise 👍 nice work
Co-authored-by: Tom Harvey <[email protected]>
Related: hashicorp/pandora#1309