Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade ember-qunit to 9.0.1 #2632

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Conversation

dchyun
Copy link
Contributor

@dchyun dchyun commented Jan 2, 2025

πŸ“Œ Summary

Upgrade the ember-qunit package from 8.1.0 to 9.0.1 in the showcase and website devDependencies.

πŸ› οΈ Detailed description

This upgrade of the ember-qunit package is part of the ongoing devDependency upgrades. This upgrade takes the library up to the latest version of ember-qunit.

The one code change required was due to a breaking change in the 9.0.0 release of ember-qunit. Changes to the start function required additional imports and function calls to align with the new blueprint recommended for starting tests.

πŸ”— External links

Jira ticket: HDS-4251


πŸ‘€ Component checklist

  • Percy was checked for any visual regression

πŸ’¬ Please consider using conventional comments when reviewing this PR.

Copy link

vercel bot commented Jan 2, 2025

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Updated (UTC)
hds-showcase βœ… Ready (Inspect) Visit Preview Jan 9, 2025 5:47pm
hds-website βœ… Ready (Inspect) Visit Preview Jan 9, 2025 5:47pm

@dchyun dchyun marked this pull request as ready for review January 2, 2025 20:17
@dchyun dchyun requested a review from a team as a code owner January 2, 2025 20:17
zamoore
zamoore previously approved these changes Jan 2, 2025
Copy link
Contributor

@zamoore zamoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. Looks like the tests are still running βœ…

@dchyun dchyun force-pushed the dchyun/upgrade-ember-qunit-to-9 branch from a5d135b to 9ffa6a1 Compare January 9, 2025 17:43
@dchyun dchyun merged commit b0e75d2 into main Jan 9, 2025
14 checks passed
@dchyun dchyun deleted the dchyun/upgrade-ember-qunit-to-9 branch January 9, 2025 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants