Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

retracting api submodule version 1.31.1 #22172

Merged
merged 3 commits into from
Feb 18, 2025
Merged

retracting api submodule version 1.31.1 #22172

merged 3 commits into from
Feb 18, 2025
+4 −0

Conversation

nitin-sachdev-29
Copy link
Contributor

Description

retracting api submodule version 1.31.1

Testing & Reproduction steps

Links

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

@nitin-sachdev-29 nitin-sachdev-29 requested a review from a team as a code owner February 18, 2025 09:22
@github-actions github-actions bot added the theme/api Relating to the HTTP API interface label Feb 18, 2025
@nitin-sachdev-29 nitin-sachdev-29 added the backport/all Apply backports for all active releases per .release/versions.hcl label Feb 18, 2025
@nitin-sachdev-29 nitin-sachdev-29 self-assigned this Feb 18, 2025
sreeram77
sreeram77 reviewed Feb 18, 2025
View reviewed changes
.changelog/22172.txt Outdated
@@ -0,0 +1,3 @@
```release-note:bug
Fixed api submodule checksum mismatch issue and retracted 1.31.1 version [[GH-22172](https://github.com/hashicorp/consul/pull/22172)]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changelog is not adhering to the format prescribed in the guide.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

sreeram77
sreeram77 reviewed Feb 18, 2025
View reviewed changes
api/go.mod Outdated
@@ -5,6 +5,7 @@ go 1.22.12
replace github.com/hashicorp/consul/sdk => ../sdk

retract (
v1.31.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a comment with the reason for retraction since this comment will be shown in the warning when someone tries to import this version.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

sreeram77
sreeram77 approved these changes Feb 18, 2025
View reviewed changes
Copy link
Member

@sreeram77 sreeram77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nitin-sachdev-29 nitin-sachdev-29 enabled auto-merge (squash) February 18, 2025 09:46
@nitin-sachdev-29 nitin-sachdev-29 merged commit 44162d6 into main Feb 18, 2025
94 checks passed
@nitin-sachdev-29 nitin-sachdev-29 deleted the nitin/api-submodule-fix branch February 18, 2025 12:34
@hc-github-team-consul-core hc-github-team-consul-core added backport/1.20 Changes are backported to 1.20 backport/ent/1.15 Changes are backported to 1.15 ent backport/ent/1.18 Changes are backported to 1.18 ent backport/ent/1.19 Changes are backported to 1.19 ent labels Feb 18, 2025
@hc-github-team-consul-core hc-github-team-consul-core mentioned this pull request Feb 18, 2025
Merged
4 tasks
@hc-github-team-consul-core
Copy link
Collaborator

📣 Hi @nitin-sachdev-29! a backport is missing for this PR [22172] for versions [1.15] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

1 similar comment
@hc-github-team-consul-core
Copy link
Collaborator

📣 Hi @nitin-sachdev-29! a backport is missing for this PR [22172] for versions [1.15] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sreeram77 sreeram77 sreeram77 approved these changes

@srahul3 srahul3 Awaiting requested review from srahul3

Assignees

@nitin-sachdev-29 nitin-sachdev-29

Labels
backport/all Apply backports for all active releases per .release/versions.hcl backport/ent/1.15 Changes are backported to 1.15 ent backport/ent/1.18 Changes are backported to 1.18 ent backport/ent/1.19 Changes are backported to 1.19 ent backport/1.20 Changes are backported to 1.20 theme/api Relating to the HTTP API interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nitin-sachdev-29 @hc-github-team-consul-core @sreeram77