Create documentation for Argo Rollouts Plugin. #20680

thisisnotashwin · 2024-02-20T20:54:16Z

Description

VERCEL LINK: https://consul-31z9s3g9y-hashicorp.vercel.app/consul/docs/k8s/deployment-configurations/argo-rollouts-configuration

Testing & Reproduction steps

Links

PR Checklist

updated test coverage
external facing docs updated
appropriate backport labels added
not a security concern

website/content/docs/k8s/deployment-configurations/argo-rollouts-configuration.mdx

website/data/docs-nav-data.json

website/content/docs/k8s/deployment-configurations/argo-rollouts-configuration.mdx

boruszak

I left suggestions to match the documentation style guide and page layouts. Approving so that you're not blocked, but there's a number of big structural changes, so please don't hesitate to reach out if you need additional review on this PR!

Approving on behalf of consul-docs

website/content/docs/k8s/deployment-configurations/argo-rollouts-configuration.mdx

Co-authored-by: Jeff Boruszak <[email protected]>

boruszak

LGTM! Just some really minor spacing/capitalization/wording suggestions to apply.

website/content/docs/k8s/deployment-configurations/argo-rollouts-configuration.mdx

Co-authored-by: Jeff Boruszak <[email protected]>

wilkermichael

Just adding some fixes to the links

website/content/docs/k8s/deployment-configurations/argo-rollouts-configuration.mdx

…ts-configuration.mdx

github-actions · 2024-05-09T01:29:07Z

This pull request has been automatically flagged for inactivity because it has not been acted upon in the last 60 days. It will be closed if no new activity occurs in the next 30 days. Please feel free to re-open to resurrect the change if you feel this has happened by mistake. Thank you for your contributions.

boruszak · 2024-06-07T20:41:51Z

@blake Should we merge these docs for the upcoming release? Argo rollouts were listed on your recent roadmap

boruszak · 2024-06-11T20:04:04Z

Update: These docs are complete, but we should not publish until Argo Rollouts v1.7 is released. Currently they're only in the release candidate: https://github.com/argoproj/argo-rollouts/releases

* Create documentation for Argo Rollouts Plugin. * Create documentation for Argo Rollouts Plugin. * Apply suggestions from code review Co-authored-by: David Yu <[email protected]> * Apply suggestions from code review Co-authored-by: Jeff Boruszak <[email protected]> * Update docs based on feedback * Apply suggestions from code review Co-authored-by: Jeff Boruszak <[email protected]> * Update website/content/docs/k8s/deployment-configurations/argo-rollouts-configuration.mdx * Update website/content/docs/k8s/deployment-configurations/argo-rollouts-configuration.mdx --------- Co-authored-by: David Yu <[email protected]> Co-authored-by: Jeff Boruszak <[email protected]> Co-authored-by: Michael Wilkerson <[email protected]>

* First commit * Add page to navigation * test new doc page * Update website/content/docs/services/discovery/dns-forwarding.mdx * Update website/content/docs/services/discovery/dns-forwarding.mdx * fix push build atttempt * Draft * Draft * empty line * Draft * empty lines * Draft * First draft * Create documentation for Argo Rollouts Plugin. (#20680) * Create documentation for Argo Rollouts Plugin. * Create documentation for Argo Rollouts Plugin. * Apply suggestions from code review Co-authored-by: David Yu <[email protected]> * Apply suggestions from code review Co-authored-by: Jeff Boruszak <[email protected]> * Update docs based on feedback * Apply suggestions from code review Co-authored-by: Jeff Boruszak <[email protected]> * Update website/content/docs/k8s/deployment-configurations/argo-rollouts-configuration.mdx * Update website/content/docs/k8s/deployment-configurations/argo-rollouts-configuration.mdx --------- Co-authored-by: David Yu <[email protected]> Co-authored-by: Jeff Boruszak <[email protected]> Co-authored-by: Michael Wilkerson <[email protected]> * Split content and add images * Fix navigation * Add links and context * Restructure changes * Fix enable documentation * Fix enable documentation * Fix index documentation * Add troubleshooting and fix codeblocks * Add troubleshooting and fix codeblocks * Typos and last checks * Apply suggestions from code review Co-authored-by: Aimee Ukasick <[email protected]> * Apply suggestions from code review Co-authored-by: Jeff Boruszak <[email protected]> * Update website/content/docs/services/discovery/dns-forwarding/enable.mdx * Apply suggestions from code review Co-authored-by: Jeff Boruszak <[email protected]> * Add dark mode images * Add dark mode images * Apply suggestions from code review --------- Co-authored-by: boruszak <[email protected]> Co-authored-by: Ashwin Venkatesh <[email protected]> Co-authored-by: David Yu <[email protected]> Co-authored-by: Jeff Boruszak <[email protected]> Co-authored-by: Michael Wilkerson <[email protected]> Co-authored-by: Aimee Ukasick <[email protected]>

…21673) * CE-655 - Moving DNS forwading tutorial to docs (#21348) * First commit * Add page to navigation * test new doc page * Update website/content/docs/services/discovery/dns-forwarding.mdx * Update website/content/docs/services/discovery/dns-forwarding.mdx * fix push build atttempt * Draft * Draft * empty line * Draft * empty lines * Draft * First draft * Create documentation for Argo Rollouts Plugin. (#20680) * Create documentation for Argo Rollouts Plugin. * Create documentation for Argo Rollouts Plugin. * Apply suggestions from code review Co-authored-by: David Yu <[email protected]> * Apply suggestions from code review Co-authored-by: Jeff Boruszak <[email protected]> * Update docs based on feedback * Apply suggestions from code review Co-authored-by: Jeff Boruszak <[email protected]> * Update website/content/docs/k8s/deployment-configurations/argo-rollouts-configuration.mdx * Update website/content/docs/k8s/deployment-configurations/argo-rollouts-configuration.mdx --------- Co-authored-by: David Yu <[email protected]> Co-authored-by: Jeff Boruszak <[email protected]> Co-authored-by: Michael Wilkerson <[email protected]> * Split content and add images * Fix navigation * Add links and context * Restructure changes * Fix enable documentation * Fix enable documentation * Fix index documentation * Add troubleshooting and fix codeblocks * Add troubleshooting and fix codeblocks * Typos and last checks * Apply suggestions from code review Co-authored-by: Aimee Ukasick <[email protected]> * Apply suggestions from code review Co-authored-by: Jeff Boruszak <[email protected]> * Update website/content/docs/services/discovery/dns-forwarding/enable.mdx * Apply suggestions from code review Co-authored-by: Jeff Boruszak <[email protected]> * Add dark mode images * Add dark mode images * Apply suggestions from code review --------- Co-authored-by: boruszak <[email protected]> Co-authored-by: Ashwin Venkatesh <[email protected]> Co-authored-by: David Yu <[email protected]> Co-authored-by: Jeff Boruszak <[email protected]> Co-authored-by: Michael Wilkerson <[email protected]> Co-authored-by: Aimee Ukasick <[email protected]> * CE-657 - Move Application leader election tutorial to docs (#21366) * First commit * Fix navigation * Add some commands * Structure draft * Complete usage doc structure * Fix link * Apply suggestions from code review Co-authored-by: Aimee Ukasick <[email protected]> * Apply suggestions from code review Co-authored-by: Jeff Boruszak <[email protected]> * Apply suggestions from code review Co-authored-by: Jeff Boruszak <[email protected]> * Apply suggestions from code review * Replace tutorial path * Apply suggestions from code review Co-authored-by: Jeff Boruszak <[email protected]> --------- Co-authored-by: Aimee Ukasick <[email protected]> Co-authored-by: Jeff Boruszak <[email protected]> Co-authored-by: boruszak <[email protected]> --------- Co-authored-by: danielehc <[email protected]> Co-authored-by: Ashwin Venkatesh <[email protected]> Co-authored-by: David Yu <[email protected]> Co-authored-by: Michael Wilkerson <[email protected]> Co-authored-by: Aimee Ukasick <[email protected]>

* First commit * Add page to navigation * test new doc page * Update website/content/docs/services/discovery/dns-forwarding.mdx * Update website/content/docs/services/discovery/dns-forwarding.mdx * fix push build atttempt * Draft * Draft * empty line * Draft * empty lines * Draft * First draft * Create documentation for Argo Rollouts Plugin. (#20680) * Create documentation for Argo Rollouts Plugin. * Create documentation for Argo Rollouts Plugin. * Apply suggestions from code review Co-authored-by: David Yu <[email protected]> * Apply suggestions from code review Co-authored-by: Jeff Boruszak <[email protected]> * Update docs based on feedback * Apply suggestions from code review Co-authored-by: Jeff Boruszak <[email protected]> * Update website/content/docs/k8s/deployment-configurations/argo-rollouts-configuration.mdx * Update website/content/docs/k8s/deployment-configurations/argo-rollouts-configuration.mdx --------- Co-authored-by: David Yu <[email protected]> Co-authored-by: Jeff Boruszak <[email protected]> Co-authored-by: Michael Wilkerson <[email protected]> * Split content and add images * Fix navigation * Add links and context * Restructure changes * Fix enable documentation * Fix enable documentation * Fix index documentation * Add troubleshooting and fix codeblocks * Add troubleshooting and fix codeblocks * Typos and last checks * Apply suggestions from code review Co-authored-by: Aimee Ukasick <[email protected]> * Apply suggestions from code review Co-authored-by: Jeff Boruszak <[email protected]> * Update website/content/docs/services/discovery/dns-forwarding/enable.mdx * Apply suggestions from code review Co-authored-by: Jeff Boruszak <[email protected]> * Add dark mode images * Add dark mode images * Apply suggestions from code review --------- Co-authored-by: boruszak <[email protected]> Co-authored-by: Ashwin Venkatesh <[email protected]> Co-authored-by: David Yu <[email protected]> Co-authored-by: Jeff Boruszak <[email protected]> Co-authored-by: Michael Wilkerson <[email protected]> Co-authored-by: Aimee Ukasick <[email protected]>

thisisnotashwin added the type/docs Documentation needs to be created/updated/clarified label Feb 20, 2024

thisisnotashwin requested review from david-yu and wilkermichael February 20, 2024 20:54

vercel bot had a problem deploying to Preview – consul February 20, 2024 20:56 Failure

thisisnotashwin force-pushed the ashwin-michael/add-docs-for-rollouts-plugin branch 2 times, most recently from 0cf4d1a to 2d4056b Compare February 20, 2024 20:59

vercel bot deployed to Preview – consul February 20, 2024 21:09 View deployment

wilkermichael added the pr/no-changelog PR does not need a corresponding .changelog entry label Feb 20, 2024

wilkermichael reviewed Feb 20, 2024

View reviewed changes

website/content/docs/k8s/deployment-configurations/argo-rollouts-configuration.mdx Outdated Show resolved Hide resolved

wilkermichael reviewed Feb 20, 2024

View reviewed changes

website/content/docs/k8s/deployment-configurations/argo-rollouts-configuration.mdx Outdated Show resolved Hide resolved

website/content/docs/k8s/deployment-configurations/argo-rollouts-configuration.mdx Outdated Show resolved Hide resolved

thisisnotashwin force-pushed the ashwin-michael/add-docs-for-rollouts-plugin branch from 2d4056b to a76a917 Compare February 21, 2024 14:53

vercel bot deployed to Preview – consul February 21, 2024 14:58 View deployment

thisisnotashwin requested a review from wilkermichael February 21, 2024 15:01

thisisnotashwin marked this pull request as ready for review February 21, 2024 15:01

thisisnotashwin requested a review from a team as a code owner February 21, 2024 15:01

vercel bot deployed to Preview – consul February 21, 2024 15:05 View deployment

thisisnotashwin force-pushed the ashwin-michael/add-docs-for-rollouts-plugin branch 2 times, most recently from f77ea18 to 4f48ba9 Compare February 21, 2024 15:17

vercel bot deployed to Preview – consul February 21, 2024 15:26 View deployment

david-yu reviewed Feb 21, 2024

View reviewed changes

website/data/docs-nav-data.json Outdated Show resolved Hide resolved

david-yu reviewed Feb 21, 2024

View reviewed changes

website/content/docs/k8s/deployment-configurations/argo-rollouts-configuration.mdx Outdated Show resolved Hide resolved

david-yu approved these changes Feb 21, 2024

View reviewed changes

wilkermichael approved these changes Feb 21, 2024

View reviewed changes

vercel bot deployed to Preview – consul February 21, 2024 18:21 View deployment

boruszak approved these changes Feb 21, 2024

View reviewed changes

Ashwin Venkatesh and others added 2 commits February 21, 2024 14:35

Apply suggestions from code review

d24cd6c

Co-authored-by: Jeff Boruszak <[email protected]>

Update docs based on feedback

5a2105c

thisisnotashwin force-pushed the ashwin-michael/add-docs-for-rollouts-plugin branch from fec02a6 to 5a2105c Compare February 21, 2024 19:35

boruszak approved these changes Feb 21, 2024

View reviewed changes

Apply suggestions from code review

c5d7394

Co-authored-by: Jeff Boruszak <[email protected]>

vercel bot deployed to Preview – consul February 21, 2024 19:49 View deployment

wilkermichael approved these changes Mar 6, 2024

View reviewed changes

website/content/docs/k8s/deployment-configurations/argo-rollouts-configuration.mdx Outdated Show resolved Hide resolved

website/content/docs/k8s/deployment-configurations/argo-rollouts-configuration.mdx Outdated Show resolved Hide resolved

wilkermichael added 2 commits March 6, 2024 10:39

Update website/content/docs/k8s/deployment-configurations/argo-rollou…

0c8cdda

…ts-configuration.mdx

Update website/content/docs/k8s/deployment-configurations/argo-rollou…

b11e148

…ts-configuration.mdx

vercel bot deployed to Preview – consul March 6, 2024 18:50 View deployment

david-yu removed the backport/1.15 This release series is no longer active on CE. Use backport/ent/1.15. label Mar 9, 2024

github-actions bot added the meta/stale Automatically flagged for inactivity by stalebot label May 9, 2024

zalimeni removed the backport/ent/1.18 label May 28, 2024

github-actions bot removed the meta/stale Automatically flagged for inactivity by stalebot label May 29, 2024

boruszak added backport/1.19 This release series is longer active on CE, use backport/ent/1.19 and removed backport/1.16 This release series is no longer active on CE. Use backport/ent/1.16. backport/1.17 This release series is no longer active on CE. Use backport/ent/1.17. labels Jun 11, 2024

boruszak mentioned this pull request Jun 11, 2024

docs: Consul v1.19 Release Notes #21279

Merged

4 tasks

wilkermichael merged commit 596a4cd into main Jun 24, 2024
97 checks passed

wilkermichael deleted the ashwin-michael/add-docs-for-rollouts-plugin branch June 24, 2024 23:32

hc-github-team-consul-core mentioned this pull request Jun 24, 2024

Backport of Create documentation for Argo Rollouts Plugin. into release/1.19.x #21362

Merged

4 tasks

dhiaayachi mentioned this pull request Sep 25, 2024

Backport of Create documentation for Argo Rollouts Plugin. into release/1.19.x dhiaayachi/consul#318

Open

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Create documentation for Argo Rollouts Plugin. #20680

Create documentation for Argo Rollouts Plugin. #20680

thisisnotashwin commented Feb 20, 2024 •

edited by wilkermichael

Loading

boruszak left a comment

boruszak left a comment

wilkermichael left a comment

github-actions bot commented May 9, 2024

boruszak commented Jun 7, 2024

boruszak commented Jun 11, 2024

Create documentation for Argo Rollouts Plugin. #20680

Create documentation for Argo Rollouts Plugin. #20680

Conversation

thisisnotashwin commented Feb 20, 2024 • edited by wilkermichael Loading

Description

Testing & Reproduction steps

Links

PR Checklist

boruszak left a comment

Choose a reason for hiding this comment

boruszak left a comment

Choose a reason for hiding this comment

wilkermichael left a comment

Choose a reason for hiding this comment

github-actions bot commented May 9, 2024

boruszak commented Jun 7, 2024

boruszak commented Jun 11, 2024

thisisnotashwin commented Feb 20, 2024 •

edited by wilkermichael

Loading