Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NET-6943 - Replace usage of deprecated Envoy field envoy.config.router.v3.WeightedCluster.total_weight. #20011

Merged
merged 1 commit into from
Dec 22, 2023

Conversation

jmurret
Copy link
Member

@jmurret jmurret commented Dec 20, 2023

Description

envoy has deprecated sending the total_weight.

Testing & Reproduction steps

Links

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

@jmurret jmurret added backport/1.15 This release series is no longer active on CE. Use backport/ent/1.15. backport/1.16 This release series is no longer active on CE. Use backport/ent/1.16. backport/1.17 This release series is no longer active on CE. Use backport/ent/1.17. labels Dec 20, 2023
@github-actions github-actions bot added the theme/envoy/xds Related to Envoy support label Dec 20, 2023
@jmurret jmurret changed the title NET-6944 - Replace usage of deprecated Envoy field envoy.config.router.v3.WeightedCluster.total_weight. NET-6943 - Replace usage of deprecated Envoy field envoy.config.router.v3.WeightedCluster.total_weight. Dec 20, 2023
@jmurret jmurret force-pushed the jm/NET-6943 branch 5 times, most recently from d5af8c7 to f15d770 Compare December 22, 2023 18:52
@jmurret jmurret marked this pull request as ready for review December 22, 2023 18:52
@jmurret jmurret force-pushed the jm/NET-6943 branch 3 times, most recently from 8f8e59a to 5382248 Compare December 22, 2023 19:09
Copy link
Member

@zalimeni zalimeni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +/- changelog

@jmurret jmurret enabled auto-merge (squash) December 22, 2023 19:24
@jmurret jmurret merged commit 2f33511 into main Dec 22, 2023
85 checks passed
@jmurret jmurret deleted the jm/NET-6943 branch December 22, 2023 19:49
jmurret added a commit that referenced this pull request Jan 2, 2024
jmurret added a commit that referenced this pull request Jan 2, 2024
jmurret added a commit that referenced this pull request Jan 2, 2024
jmurret added a commit that referenced this pull request Jan 2, 2024
jmurret added a commit that referenced this pull request Jan 2, 2024
jmurret added a commit that referenced this pull request Jan 2, 2024
jmurret added a commit that referenced this pull request Jan 2, 2024
jmurret added a commit that referenced this pull request Jan 2, 2024
jmurret added a commit that referenced this pull request Jan 2, 2024
…config.router.v3.WeightedCluster.total_weight. into release/1.16.x (#20060)

* no-op commit due to failed cherry-picking

* NET-6943 - Replace usage of deprecated Envoy field envoy.config.router.v3.WeightedCluster.total_weight. (#20011)

---------

Co-authored-by: temp <[email protected]>
Co-authored-by: John Murret <[email protected]>
jmurret added a commit that referenced this pull request Jan 2, 2024
…config.router.v3.WeightedCluster.total_weight. into release/1.17.x (#20061)

* no-op commit due to failed cherry-picking

* NET-6943 - Replace usage of deprecated Envoy field envoy.config.router.v3.WeightedCluster.total_weight. (#20011)

---------

Co-authored-by: temp <[email protected]>
Co-authored-by: John Murret <[email protected]>
jmurret added a commit that referenced this pull request Jan 2, 2024
…config.router.v3.WeightedCluster.total_weight. into release/1.15.x (#20059)

NET-6943 - Replace usage of deprecated Envoy field envoy.config.router.v3.WeightedCluster.total_weight. (#20011)

Co-authored-by: John Murret <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/1.15 This release series is no longer active on CE. Use backport/ent/1.15. backport/1.16 This release series is no longer active on CE. Use backport/ent/1.16. backport/1.17 This release series is no longer active on CE. Use backport/ent/1.17. theme/envoy/xds Related to Envoy support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants