Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add test which has been removed for metrics to unblock CI #19927

Conversation

valeriia-ruban
Copy link
Contributor

@valeriia-ruban valeriia-ruban commented Dec 13, 2023

Description

https://hashicorp.atlassian.net/browse/CC-7062

Testing & Reproduction steps

Links

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

@github-actions github-actions bot added the theme/ui Anything related to the UI label Dec 13, 2023
@valeriia-ruban valeriia-ruban added pr/no-changelog PR does not need a corresponding .changelog entry backport/1.17 This release series is no longer active on CE. Use backport/ent/1.17. pr/no-metrics-test labels Dec 13, 2023
@valeriia-ruban valeriia-ruban marked this pull request as ready for review December 19, 2023 20:50
@WenInCode
Copy link
Contributor

@valeriia-ruban it looks like the frontend tests haven't run at all?

@valeriia-ruban
Copy link
Contributor Author

@valeriia-ruban it looks like the frontend tests haven't run at all?

Great catch @WenInCode! The thing is that I've triggered them one more time after ✅ run, just to make one more attempt to make sure there is no flakey tests bubble, but something goes wrong on a github checks side
image

So hopefully it will be gone itself once the branch is updated or/and the frontend github checks are triggered

@valeriia-ruban
Copy link
Contributor Author

closing the pr due to difficulties with updating it in github (by some chance git rejects an update of the branch to current main, doesn't matter if it is rebased or just pulled there). so for saving time on battling it I just opened a new one with the newest main as base

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/1.17 This release series is no longer active on CE. Use backport/ent/1.17. pr/no-changelog PR does not need a corresponding .changelog entry pr/no-metrics-test theme/ui Anything related to the UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants