Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport of Stop use of templated-policy and templated-policy-file simultaneously into release/1.17.x #19390

Merged
merged 1 commit into from
Oct 26, 2023
Merged

Backport of Stop use of templated-policy and templated-policy-file simultaneously into release/1.17.x #19390

merged 1 commit into from
Oct 26, 2023

Conversation

hc-github-team-consul-core
Copy link
Collaborator

Backport

This PR is auto-generated from #19389 to be assessed for backporting due to the inclusion of the label backport/1.17.

The below text is copied from the body of the original PR.

Description

  • Prevent usage of templated-policy and templated-policy-file simultaneously to improve ux for templated policy use

Testing & Reproduction steps

consul acl token create -templated-policy "builtin/service" -templated-policy-file "templatedpolicy.hcl"

Cannot combine the use of templated-policy flag with templated-policy-file. To create a token with a single templated policy and simple use case, use -templated-policy. For multiple templated policies and more complicated use cases, use -templated-policy-file

PR Checklist

  • updated test coverage
  • appropriate backport labels added
  • not a security concern
Overview of commits

@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/ux-improvement-tp/incredibly-helping-moose branch from ae4d657 to f6f1241 Compare October 26, 2023 18:15
@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/ux-improvement-tp/incredibly-helping-moose branch from a758adb to 0da3582 Compare October 26, 2023 18:15
github-team-consul-core-pr-approver
github-team-consul-core-pr-approver approved these changes Oct 26, 2023
View reviewed changes
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto approved Consul Bot automated PR

@github-actions github-actions bot added the theme/cli Flags and documentation for the CLI interface label Oct 26, 2023
@hc-github-team-consul-core hc-github-team-consul-core merged commit ebc7d4e into release/1.17.x Oct 26, 2023
@hc-github-team-consul-core hc-github-team-consul-core deleted the backport/ux-improvement-tp/incredibly-helping-moose branch October 26, 2023 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-team-consul-core-pr-approver github-team-consul-core-pr-approver github-team-consul-core-pr-approver approved these changes

@roncodingenthusiast roncodingenthusiast Awaiting requested review from roncodingenthusiast

Assignees

@roncodingenthusiast roncodingenthusiast

Labels
theme/cli Flags and documentation for the CLI interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hc-github-team-consul-core @github-team-consul-core-pr-approver @roncodingenthusiast