Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of feat: Change global-read-only policy to non editable into release/1.15.x #18750

Conversation

hc-github-team-consul-core
Copy link
Collaborator

Backport

This PR is auto-generated from #18602 to be assessed for backporting due to the inclusion of the label backport/1.15.

🚨

Warning automatic cherry-pick of commits failed. If the first commit failed,
you will see a blank no-op commit below. If at least one commit succeeded, you
will see the cherry-picked commits up to, not including, the commit where
the merge conflict occurred.

The person who merged in the original PR is:
@valeriia-ruban
This person should manually cherry-pick the original PR into a new backport PR,
and close this one when the manual backport PR is merged in.

merge conflict error: POST https://api.github.com/repos/hashicorp/consul/merges: 409 Merge conflict []

The below text is copied from the body of the original PR.


Description

Update global-read-only to non editable
image
image

Testing & Reproduction steps

  1. set up CONSUL_ACLS_ENABLE to 1 in session storage
  2. set CONSUL_POLICY_COUNT = 10
  3. go to Policies
  4. log in with any securId
  5. check list of items to see global-read-only policy
  6. go to the policy details and check that form is non-editable

Links

JIRA
Figma

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

Overview of commits

@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/ui/feature/make-global-read-only-policy-non-editable/instantly-hardy-chamois branch from 8983992 to 9e038b9 Compare September 11, 2023 21:21
@hashicorp-cla
Copy link

hashicorp-cla commented Sep 11, 2023

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes


1 out of 2 committers have signed the CLA.

  • valeriia-ruban
  • temp

temp seems not to be a GitHub user.
You need a GitHub account to be able to sign the CLA. If you already have a GitHub account, please add the email address used for this commit to your account.

Have you signed the CLA already but the status is still pending? Recheck it.

@vercel vercel bot temporarily deployed to Preview – consul-ui-staging September 11, 2023 21:21 Inactive
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto approved Consul Bot automated PR

…ad-only-policy-non-editable/instantly-hardy-chamois
…itable/instantly-hardy-chamois' of github.com:hashicorp/consul into backport/ui/feature/make-global-read-only-policy-non-editable/instantly-hardy-chamois
…ad-only-policy-non-editable/instantly-hardy-chamois
auto-merge was automatically disabled November 7, 2023 19:17

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme/ui Anything related to the UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants