Backport of docs: Update K8s TGW tutorial to reliably obtain role ID into release/1.13.x #18492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-consul-core
force-pushed
the
backport/docs/k8s-tgw-tutorial-role-id-fix/duly-known-shad
branch
from
755306b to
69adf73
Compare
hc-github-team-consul-core
force-pushed
the
backport/docs/k8s-tgw-tutorial-role-id-fix/duly-known-shad
branch
from
69adf73 to
755306b
Compare
|
|
github-team-consul-core-pr-approver
approved these changes
Aug 16, 2023
blake
force-pushed
the
backport/docs/k8s-tgw-tutorial-role-id-fix/duly-known-shad
branch
from
78344e8 to
916c838
Compare
The `grep` command used to obtain the ID for the terminating gateway role is not reliable in all scenarios. For example, if there is a similarly named role, the command may return the wrong role ID for the active terminating gateway instance. This commit updates the command to use jq to obtain the role ID. If multiple roles are found, jq will raise an error informing the user that it cannot reliably determine the role ID.
blake
force-pushed
the
backport/docs/k8s-tgw-tutorial-role-id-fix/duly-known-shad
branch
from
916c838 to
0bfad6d
Compare
|
This pull request has been automatically flagged for inactivity because it has not been acted upon in the last 60 days. It will be closed if no new activity occurs in the next 30 days. Please feel free to re-open to resurrect the change if you feel this has happened by mistake. Thank you for your contributions. |
github-actions
bot
added
the
meta/stale
|
Closing due to inactivity. If you feel this was a mistake or you wish to re-open at any time in the future, please leave a comment and it will be re-surfaced for the maintainers to review. |
auto-merge was automatically disabled
November 17, 2023 01:29
Pull request was closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #18474 to be assessed for backporting due to the inclusion of the label backport/1.13.
🚨
The person who merged in the original PR is:
@blake
This person should manually cherry-pick the original PR into a new backport PR,
and close this one when the manual backport PR is merged in.
The below text is copied from the body of the original PR.
The
grepcommand used to obtain the ID for the terminating gateway role is not reliable in all scenarios. For example, if there is a similarly named role, the command may return the wrong role ID for the active terminating gateway instance.This commit updates the command to use jq to obtain the role ID. If multiple roles are found, jq will raise an error informing the user that it cannot reliably determine the role ID.
Description
Testing & Reproduction steps
Links
PR Checklist
Overview of commits