Revert commenting of go.mod replaces #17630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Other recent releases have not commented out the replace directives in go.mod. Though it would be ideal to pin our submodules in the release artifacts we produce, we need to tidy up our build pipeline to make this feasible. In the meantime, revert this change to keep the dependency entry updates, but exclude them from the effective dependency tree.
zalimeni
added
pr/dependencies
roncodingenthusiast
approved these changes
Jun 9, 2023
|
cc @nathancoleman re: our change in #17626 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Other recent releases have not commented out the replace directives in
go.mod. Though it would be ideal to pin our submodules in the release artifacts we produce, we need to tidy up our build pipeline to make this feasible.In the meantime, revert this change to keep the dependency entry updates, but exclude them from the effective dependency tree.
PR Checklist