Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of remove deprecated set-output calls in gha into release/1.14.x #17509

Conversation

hc-github-team-consul-core
Copy link
Collaborator

Backport

This PR is auto-generated from #17494 to be assessed for backporting due to the inclusion of the label backport/1.14.

🚨

Warning automatic cherry-pick of commits failed. If the first commit failed,
you will see a blank no-op commit below. If at least one commit succeeded, you
will see the cherry-picked commits up to, not including, the commit where
the merge conflict occurred.

The person who merged in the original PR is:
@modrake
This person should manually cherry-pick the original PR into a new backport PR,
and close this one when the manual backport PR is merged in.

merge conflict error: POST https://api.github.com/repos/hashicorp/consul/merges: 409 Merge conflict []

The below text is copied from the body of the original PR.


Description

This addresses the deprecation of the "set-output" command by Github.

Links

https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/ for details on this deprecation

PR Checklist

  • appropriate backport labels added
  • not a security concern

Overview of commits

@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/patch-set-output-deprecation/hopelessly-workable-civet branch from 8294eb3 to 96bb646 Compare May 30, 2023 15:18
@hashicorp-cla
Copy link

hashicorp-cla commented May 30, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto approved Consul Bot automated PR

@vercel vercel bot temporarily deployed to Preview – consul May 30, 2023 15:23 Inactive
@loshz loshz force-pushed the backport/patch-set-output-deprecation/hopelessly-workable-civet branch from 5cada3c to a0bb1aa Compare June 1, 2023 09:22
@loshz loshz marked this pull request as ready for review June 1, 2023 09:22
@loshz loshz requested a review from a team June 1, 2023 09:22
@loshz loshz requested a review from a team as a code owner June 1, 2023 09:22
@loshz loshz requested review from smacfarlane and removed request for a team June 1, 2023 09:22
@loshz loshz enabled auto-merge (squash) June 1, 2023 09:22
@loshz loshz merged commit 77f18d2 into release/1.14.x Jun 1, 2023
@loshz loshz deleted the backport/patch-set-output-deprecation/hopelessly-workable-civet branch June 1, 2023 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants