Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of feat: set up reporting agent into release/1.14.x #17024

Conversation

hc-github-team-consul-core
Copy link
Collaborator

Backport

This PR is auto-generated from #16991 to be assessed for backporting due to the inclusion of the label backport/1.14.

WARNING automatic cherry-pick of commits failed. Commits will require human attention.

merge conflict error: POST https://api.github.com/repos/hashicorp/consul/merges: 409 Merge conflict []

The below text is copied from the body of the original PR.


Description

Adds reporting agent set up which is no-op at the moment

Testing & Reproduction steps

Confirmed no reporting logs are emitted when ran locally via consul agent -dev

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

Overview of commits

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto approved Consul Bot automated PR

@hashicorp-cla
Copy link

hashicorp-cla commented Apr 18, 2023

CLA assistant check
All committers have signed the CLA.

@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/NET-3474/start-reporting-agent/initially-probable-starling branch 2 times, most recently from 8b28a7e to 4a58b22 Compare April 18, 2023 15:09
@JadhavPoonam JadhavPoonam force-pushed the backport/NET-3474/start-reporting-agent/initially-probable-starling branch from ffbaf30 to 72034fb Compare April 18, 2023 19:57
@JadhavPoonam JadhavPoonam requested review from dhiaayachi and removed request for JadhavPoonam April 19, 2023 18:18
@JadhavPoonam JadhavPoonam marked this pull request as ready for review April 19, 2023 18:19
Copy link
Collaborator

@dhiaayachi dhiaayachi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@JadhavPoonam JadhavPoonam self-assigned this May 1, 2023
@JadhavPoonam JadhavPoonam merged commit 002aea4 into release/1.14.x May 8, 2023
@JadhavPoonam JadhavPoonam deleted the backport/NET-3474/start-reporting-agent/initially-probable-starling branch May 8, 2023 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants