Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(lint): gosimple #1773

Merged
merged 1 commit into from
Aug 10, 2023
Merged

chore(lint): gosimple #1773

merged 1 commit into from
Aug 10, 2023

Conversation

thevilledev
Copy link
Contributor

Lint fixes as per the gosimple linter:

  • S1025: should use String() instead of fmt.Sprintf
  • S1000: should use a simple channel send/receive instead of 'select' with a single case
  • S1039: unnecessary use of fmt.Sprintf
  • S1008: should use 'return b != nil' instead of 'if b == nil { return false }; return true
  • S1012: should use 'time.Since' instead of 'time.Now().Sub'

@thevilledev thevilledev requested a review from a team as a code owner June 30, 2023 12:51
@thevilledev thevilledev requested review from roncodingenthusiast and removed request for a team June 30, 2023 12:51
@thevilledev thevilledev mentioned this pull request Jun 30, 2023
Merged
@roncodingenthusiast roncodingenthusiast merged commit 1842bef into hashicorp:main Aug 10, 2023
@thevilledev thevilledev deleted the chore/gosimple branch August 11, 2023 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roncodingenthusiast roncodingenthusiast Awaiting requested review from roncodingenthusiast roncodingenthusiast was automatically assigned from hashicorp/zts-template-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thevilledev @roncodingenthusiast