configurable lease check wait for non-renewable secrets #1546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now the vault config has a `lease_renewal_threshold` parameter which controls the fraction of how long of the original lease duration consul-template should wait to ask for a new secret on non-renewable secrets (like for PKIs). By default, consul-template will wait (90 +/- 5)% of the lease time.
|
|
eikenb
reviewed
Mar 8, 2022
| @@ -310,8 +328,9 @@ func (c *VaultConfig) GoString() string { | |||
| "Token:%t, "+ | |||
| "VaultAgentTokenFile:%t, "+ | |||
| "Transport:%#v, "+ | |||
| "UnwrapToken:%s"+ | |||
| "UnwrapToken:%s, "+ | |||
There was a problem hiding this comment.
Drive-by formatting fix. Thanks!
There was a problem hiding this comment.
I was trying to figure out why the unit tests would not pass, and I noticed this typo when my print statements were all weird.
eikenb
approved these changes
Mar 8, 2022
eikenb
added
the
hashicat-update-required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be a fix for #1526
Now the vault config has a
lease_renewal_thresholdparameter which controls thefraction of how long of the original lease duration consul-template should wait to
ask for a new secret on non-renewable secrets (like for PKIs). By default, consul-template
will wait (90 +/- 5)% of the lease time.