no shell call on single command exec on *nix #1509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eikenb
force-pushed
the
issue-1508-no-sh-single-command
branch
from
10c36d9 to
d211c64
Compare
|
Updated with a couple common 'sh' absolute paths as fallbacks to check if it can't find it on PATH. Updated the docs for the new exec/command semantics. |
findkim
approved these changes
Aug 25, 2021
eikenb
force-pushed
the
issue-1508-no-sh-single-command
branch
from
d211c64 to
5884385
Compare
Instead of always using `sh -c` to run command lines on *nix check if it is a single command (no spaces) and, if so, run that command directly. This will give users on systems without 'sh' a way to run their commands. Fixes #1508
eikenb
force-pushed
the
issue-1508-no-sh-single-command
branch
from
5884385 to
0357a32
Compare
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of always using
sh -cto run command lines on *nix check if itis a single command (no spaces) and, if so, run that command directly.
This will give users on systems without 'sh' a way to run their commands.
Fixes #1508