Skip to content

Commit

Permalink
Ensure that nomad config is copied over when not nil
Browse files Browse the repository at this point in the history
  • Loading branch information
peteski22 authored and eikenb committed Oct 4, 2022
1 parent bf05ae5 commit f3e8f8a
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
with:
go-version: ${{ matrix.go }}

- name: Install Consul and Vault for integration testing
- name: Install Consul, Vault and Nomad for integration testing
run: |
curl -fsSL https://apt.releases.hashicorp.com/gpg | sudo apt-key add -
sudo apt-add-repository "deb [arch=amd64] https://apt.releases.hashicorp.com $(lsb_release -cs) main"
Expand Down
2 changes: 1 addition & 1 deletion config/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ func (c *Config) Copy() *Config {
o.BlockQueryWaitTime = c.BlockQueryWaitTime

if c.Nomad != nil {
o.Nomad = o.Nomad.Copy()
o.Nomad = c.Nomad.Copy()
}

return &o
Expand Down
4 changes: 2 additions & 2 deletions manager/runner_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -1155,8 +1155,8 @@ func TestRunner_command(t *testing.T) {
case stderr.Len() > 0:
t.Errorf("unexpected error output: %s", stderr.String())
case tc.out != stdout.String():
t.Errorf("wrong command output\n got: '%#v'\nwanted: '%#v'",
stdout.String(), tc.out)
t.Errorf("wrong command output: %s \n got: '%#v'\nwanted: '%#v'",
tc.name, stdout.String(), tc.out)
}
}
for i, tc := range []testCase{
Expand Down

0 comments on commit f3e8f8a

Please sign in to comment.