Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FLAKEY_TEST: Add retry to outbound request for ProxyLifecycleShutdown… #3999

Merged
merged 3 commits into from
May 17, 2024
Merged

FLAKEY_TEST: Add retry to outbound request for ProxyLifecycleShutdown… #3999

merged 3 commits into from
May 17, 2024

Conversation

NiniOak
Copy link
Collaborator

@NiniOak NiniOak commented May 16, 2024 •
edited
Loading

Changes proposed in this PR

  • Test fails intermittently in CI (for some reason it only fails in cloud environment not kind clusters) see example here
  • Add retry to outbound API calls to improve chance of success.
    • if error occures, log the error and mark the current attempt as failed, trigger a retry.
    • If error does not exist, check if the output contains the specific error message. If the condition fails, log the error message and trigger a retry.

How I've tested this PR

CI should pass

How I expect reviewers to test this PR

CI should pass

Checklist

@NiniOak NiniOak added backport/1.1.x Backport to release/1.1.x branch pr/no-changelog PR does not need a corresponding .changelog entry backport/1.2.x This release branch is no longer active. backport/1.3.x This release branch is no longer active. backport/1.4.x labels May 16, 2024
@NiniOak NiniOak requested review from a team, nathancoleman and jm96441n and removed request for a team May 16, 2024 17:45
@NiniOak NiniOak force-pushed the fix_flakey_ProxyLifecycleShutdownTest branch from de1aa38 to b7ecab4 Compare May 16, 2024 23:14
@NiniOak NiniOak merged commit 9518284 into main May 17, 2024
43 of 50 checks passed
@NiniOak NiniOak deleted the fix_flakey_ProxyLifecycleShutdownTest branch May 17, 2024 17:18
This was referenced May 17, 2024
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@missylbytes missylbytes missylbytes approved these changes

@nathancoleman nathancoleman Awaiting requested review from nathancoleman nathancoleman was automatically assigned from hashicorp/consul-api-gateway

@jm96441n jm96441n Awaiting requested review from jm96441n jm96441n was automatically assigned from hashicorp/consul-api-gateway

Assignees
No one assigned
Labels
backport/1.1.x Backport to release/1.1.x branch backport/1.2.x This release branch is no longer active. backport/1.3.x This release branch is no longer active. backport/1.4.x pr/no-changelog PR does not need a corresponding .changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NiniOak @missylbytes