first test for to catalog registration type

control-plane/api/v1alpha1/registration_types_test.go

@@ -0,0 +1,54 @@
+package v1alpha1
+
+import (
+	"testing"
+
+	capi "github.com/hashicorp/consul/api"
+
+	"github.com/stretchr/testify/require"
+)
+
+func TestToCatalogRegistration(tt *testing.T) {
+	cases := map[string]struct {
+		registration *Registration
+		expected     *capi.CatalogRegistration
+	}{
+		"minimal registration": {
+			registration: &Registration{
+				Spec: RegistrationSpec{
+					ID:         "node-id",
+					Node:       "node-virtual",
+					Address:    "127.0.0.1",
+					Datacenter: "dc1",
+					Service: Service{
+						ID:      "service-id",
+						Name:    "service-name",
+						Port:    8080,
+						Address: "127.0.0.1",
+					},
+				},
+			},
+			expected: &capi.CatalogRegistration{
+				ID:         "node-id",
+				Node:       "node-virtual",
+				Address:    "127.0.0.1",
+				Datacenter: "dc1",
+				Service: &capi.AgentService{
+					ID:      "service-id",
+					Service: "service-name",
+					Port:    8080,
+					Address: "127.0.0.1",
+				},
+			},
+		},
+	}
+
+	for name, tc := range cases {
+		tc := tc
+		tt.Run(name, func(t *testing.T) {
+			t.Parallel()
+			actual := tc.registration.ToCatalogRegistration()
+			require.Equal(t, tc.expected, actual)
+		})
+	}
+}

control-plane/controllers/configentries/registrations_controller_test.go

@@ -94,6 +94,7 @@
 
 	for name, tc := range cases {
 		tt.Run(name, func(t *testing.T) {
+			t.Parallel()
 			s := runtime.NewScheme()
 			s.AddKnownTypes(v1alpha1.GroupVersion, &v1alpha1.Registration{})
 			ctx := context.Background()
@@ -115,7 +116,7 @@
 				Watcher: test.MockConnMgrForIPAndPort(t, host, port, false),
 			}
 
 			fakeClient := fake.NewClientBuilder().WithScheme(s).WithRuntimeObjects(tc.registration).Build()
 
 			controller := &configentries.RegistrationsController{
 				Client:              fakeClient,
@@ -126,12 +127,12 @@
 			}
 
 			_, err = controller.Reconcile(ctx, ctrl.Request{
 				NamespacedName: types.NamespacedName{Name: tc.registration.Name, Namespace: tc.registration.Namespace},
 			})
 			require.NoError(t, err)
 
 			fetchedReg := &v1alpha1.Registration{TypeMeta: metav1.TypeMeta{APIVersion: "consul.hashicorp.com/v1alpha1", Kind: "Registration"}}
 			fakeClient.Get(ctx, types.NamespacedName{Name: tc.registration.Name}, fetchedReg)
 
 			require.Len(t, fetchedReg.Status.Conditions, len(tc.expectedConditions))
 
@@ -215,6 +216,7 @@
 
 	for name, tc := range cases {
 		tt.Run(name, func(t *testing.T) {
+			t.Parallel()
 			s := runtime.NewScheme()
 			s.AddKnownTypes(v1alpha1.GroupVersion, &v1alpha1.Registration{})
 			ctx := context.Background()