add probes now that expose paths are supported #3096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndhanushkodi
commented
Oct 17, 2023
| @@ -35,6 +35,7 @@ func TestMeshInject_MultiportService(t *testing.T) { | |||
|
|
|||
| helmValues := map[string]string{ | |||
| "global.experiments[0]": "resource-apis", | |||
| "global.image": "ndhanushkodi/consul-dev:expose2", | |||
There was a problem hiding this comment.
I can remove this once the change is in the consul image being used here
There was a problem hiding this comment.
Just to save you the time checking: hashicorppreview/consul:1.17-dev and hashicorppreview/consul:1.17.0 were published this AM, so I think you're good!
DanStough
approved these changes
Oct 17, 2023
|
@DanStough oh yeah, so before making fixes in consul, it the multiport pod wouldn't come up with the probes, so I saw it crashloop, and the fact that it came up and the rest of the test could run means probes are working |
|
I was thinking of the webhook unit test, but I don't think it's a big deal. |
|
@DanStough ahhh got it |
thisisnotashwin
approved these changes
Oct 18, 2023
ndhanushkodi
added
backport/1.3.x
DanStough
force-pushed
the
nd/fix-expose-paths
branch
from
7a279d9 to
5fa62b8
Compare
2 tasks
DanStough
pushed a commit
that referenced
this pull request
Oct 19, 2023
thisisnotashwin
pushed a commit
that referenced
this pull request
Oct 20, 2023
Co-authored-by: Nitya Dhanushkodi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
How I've tested this PR:
How I expect reviewers to test this PR:
Checklist: