default to dataplane being supported when checking version annotation #1731
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
Eric ran into this when using an image built from our pipeline that builds images from main. It has a version formatted like "v1.0.0-dev ()" which is not a recognized version by the client health checks code and causes endpoints controller to think that consul-dataplane is not supported and attempt to register client health checks which won't work.
We would have run into this with our released image as well since they are built the same way as the images from main. We did NOT run into this in acceptance tests because the images built for acceptance tests are built differently and do not have the () part.
In the future we will fix our pipelines to include versions that can be parsed by the go-version library, but talking to @ishustava, we don't want to do that so close to the release.
Checklist:
- [ ] CHANGELOG entry added