This repository has been archived by the owner on Aug 25, 2021. It is now read-only.
Update proxy defaults #928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thisisnotashwin
requested review from
ishustava,
a team and
kschoche
and removed request for
a team
kschoche
reviewed
Apr 26, 2021
kschoche
approved these changes
Apr 26, 2021
thisisnotashwin
force-pushed
the
update-proxy-defaults
branch
from
1c398b9 to
e156854
Compare
thisisnotashwin
force-pushed
the
update-service-defaults
branch
from
fb57a27 to
967cd64
Compare
thisisnotashwin
force-pushed
the
update-proxy-defaults
branch
3 times, most recently
from
fd6915a to
787e1f9
Compare
thisisnotashwin
force-pushed
the
update-service-defaults
branch
from
967cd64 to
f17cbb4
Compare
thisisnotashwin
force-pushed
the
update-proxy-defaults
branch
from
787e1f9 to
957cb3c
Compare
ishustava
approved these changes
Apr 26, 2021
thisisnotashwin
force-pushed
the
update-service-defaults
branch
3 times, most recently
from
314c500 to
f93400a
Compare
thisisnotashwin
force-pushed
the
update-proxy-defaults
branch
from
957cb3c to
ac7c413
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
modeto ProxyDefaults CRD. This field is not expected to be set by actual users of the CRD but the change has been made to ensure consistency between the fields supported by Consul and those supported by the config entry CRDsHow I've tested this PR: Acceptance tests
How I expect reviewers to test this PR: Code review/review description
Checklist: