-
Notifications
You must be signed in to change notification settings - Fork 385
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that the ideal fix here is to implement a startup probe and possibly leave the existing probes as is, or loosen them just a little. What are your thoughts?
I think this will have an added effect of delaying connect's startup for 30s .. which is possibly 29s too long if this issue only creeps up in certain environments.
What do you think?
Oh you're totally right, will fix!! |
@kschoche updated! |
BUG FIXES: | ||
* Add startup probe to connect-inject deployment to give time for certificates to be available. | ||
Previously, the deployment could be killed by Kubernetes and crash loop because certificates would take a couple | ||
of seconds. [[GH-885](https://github.com/hashicorp/consul-helm/pull/885)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
of seconds. [[GH-885](https://github.com/hashicorp/consul-helm/pull/885)] | |
of seconds to be available. [[GH-885](https://github.com/hashicorp/consul-helm/pull/885)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!! 🥇
Getting certificates can take a couple of seconds
cc41c8c
to
c492ecc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Getting certificates can take a couple of seconds
Fixes #610, may fix hashicorp/consul-k8s#451
How I've tested this PR:
kind
and saw how container would be ready in ~10sHow I expect reviewers to test this PR:
Checklist: