Skip to content
This repository has been archived by the owner on Aug 25, 2021. It is now read-only.

change apiVersion to v2 for Chart.yaml #868

Merged
merged 2 commits into from
Mar 18, 2021
Merged

change apiVersion to v2 for Chart.yaml #868

merged 2 commits into from
Mar 18, 2021

Conversation

david-yu
Copy link
Contributor

apiVersion sets the apiVersion to dictate whether a chart is Helm 2 or Helm 3. Helm 3 is currently on apiVersion v2, and as of release 0.30.0 we only support Helm 3.

Changes proposed in this PR:

  • Change apiVersion for chart to v2

How I've tested this PR:

How I expect reviewers to test this PR:

Checklist:

  • Bats tests added
  • CHANGELOG entry added (HashiCorp engineers only, community PRs should not add a changelog entry)

apiVersion[https://helm.sh/docs/topics/charts/#the-apiversion-field] sets the apiVersion to dictate whether a chart is Helmv2 or Helmv3. Helmv3 is currently on apiVersion `v2`
Copy link

@thisisnotashwin thisisnotashwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks excellent!! Can you add a changelog entry as well that mentions this update?

Updating release note with apiVersion set to `v2`
@david-yu
Copy link
Contributor Author

@thisisnotashwin does the changelog look ok?

Copy link

@thisisnotashwin thisisnotashwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it does @david-yu !!

@david-yu david-yu merged commit 9d619d4 into master Mar 18, 2021
@david-yu david-yu deleted the david-yu-patch-1 branch March 18, 2021 17:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants