Rename lifecycle-sidecar to consul-sidecar #810
Conversation
.circleci/config.yml
Outdated
| @@ -155,7 +155,7 @@ jobs: | |||
| -kubecontext="kind-dc1" \ | |||
| -secondary-kubecontext="kind-dc2" \ | |||
| -debug-directory="$TEST_RESULTS/debug" \ | |||
| -consul-k8s-image=docker.mirror.hashicorp.services/hashicorpdev/consul-k8s:latest | |||
| -consul-k8s-image=docker.mirror.hashicorp.services/hashicorpdev/consul-k8s@sha256:d158c0b4956421889e7ba80d82c24baa365c5cd3148dac62b555b4c9ba800c0a | |||
| then | |||
There was a problem hiding this comment.
Will be removed before merging. This is to use the docker image built for the corresponding consul-k8s change when running acceptance tests.
ndhanushkodi
force-pushed
the
rename-sidecar
branch
from
1705cb3 to
3960f4d
Compare
.circleci/config.yml
Outdated
| @@ -155,7 +155,7 @@ jobs: | |||
| -kubecontext="kind-dc1" \ | |||
There was a problem hiding this comment.
Does it make sense to change references to lifecycle-sidecar in hack/helm-reference-gen to also use consul-sidecar? I figure the exact values are getting stale anyway and that the use is meant to test that nested nodes work, etc.
There was a problem hiding this comment.
Yup!! That sounds right. It would be nice if the fixture looked even lesser like our values file because it definitely is confusing. I don't think it needs to be updated and can be left as is.
ndhanushkodi
requested review from
a team and
ishustava
and removed request for
a team
There was a problem hiding this comment.
This looks great!! Excellent work on the pair of PRs @ndhanushkodi
.circleci/config.yml
Outdated
| @@ -155,7 +155,7 @@ jobs: | |||
| -kubecontext="kind-dc1" \ | |||
There was a problem hiding this comment.
Yup!! That sounds right. It would be nice if the fixture looked even lesser like our values file because it definitely is confusing. I don't think it needs to be updated and can be left as is.
ndhanushkodi
force-pushed
the
rename-sidecar
branch
from
3960f4d to
5f86391
Compare
This commit deprecates helm value lifecycleSidecarContainer and replaces it with consulSidecarContainer. It also replaces all uses of lifecycle sidecar with consul sidecar, including container names, commands, and flags. This is to enable future functionality within the consul-sidecar container, since it may no longer be only responsible for managing lifecycle.
ndhanushkodi
force-pushed
the
rename-sidecar
branch
from
5f86391 to
de8464b
Compare
Changes proposed in this PR:
consulSidecarContainer.
with consul sidecar, including container names, commands, and flags.
This is to enable future functionality within the consul-sidecar
container, since it may no longer be only responsible for managing
lifecycle.
How I've tested this PR:
acceptance tests against consul-k8s rename-sidecar branch
How I expect reviewers to test this PR:
code review
Checklist: