This repository has been archived by the owner on Aug 25, 2021. It is now read-only.
Drop support for Helm 2 #807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lkysow
force-pushed
the
parallel-unit-tests
branch
3 times, most recently
from
4f418ea to
fc7f670
Compare
* Remove unit test cases for Helm 2 * Update docs * Remove circle ci step
lkysow
force-pushed
the
parallel-unit-tests
branch
from
fc7f670 to
2ce0e50
Compare
lkysow
commented
Feb 12, 2021
| @@ -60,61 +60,56 @@ load _helpers | |||
| } | |||
|
|
|||
| @test "ui/Ingress: exposes single port 80 when global.tls.enabled=false" { | |||
There was a problem hiding this comment.
Helm 3 does not support the --kube-version flag yet so we can't test this permutation until the linked PR is merged. That PR is active so I thought it best to leave these commented out so once it gets merged it's easy to uncomment vs. digging through git history.
lkysow
requested review from
a team,
ndhanushkodi and
ishustava
and removed request for
a team
ishustava
approved these changes
Feb 16, 2021
ndhanushkodi
approved these changes
Feb 16, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RELEASE-NAMEso need to use thatAccording to https://app.circleci.com/insights/github/hashicorp/consul-helm/workflows/test/jobs?reporting-window=last-90-days the p95 for helm3 is 7m 49s and 9m 2s.
This looks like the helm3 tests are now running in 4m.