This repository has been archived by the owner on Aug 25, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 385
Openshift support #600
Merged
Openshift support #600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
46ee3fc
to
821ace0
Compare
3b591d2
to
466b27c
Compare
ishustava
commented
Oct 2, 2020
test/acceptance/tests/terminating-gateway/terminating_gateway_namespaces_test.go
Show resolved
Hide resolved
ishustava
commented
Oct 2, 2020
lkysow
approved these changes
Oct 2, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 🦊 Looks simple enough 😆
kschoche
approved these changes
Oct 5, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @ishustava!!
One quick question about the comments in values.yaml :
Does it make sense to add a comment saying
"this has been tested on openshift version X?"
so that users have an idea of what a supportable version would be?
yeah! I think that's a great idea! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR
Helm chart values and template changes
global.openshift.enabled
SecurityContextConstraint
for the consul clients whenglobal.openshift.enabled
is set to trueglobal.openshift.enabled
is set to trueserver.disableFsGroupSecurityContext
value and fail in the chart if someone tries to set it25Mi
to50Mi
for all jobs and service-init containers in the terminating and ingress gateway deployments. This was mostly determined by running the tests. There are other containers that still have the25Mi
memory request and limit, however those containers were not causing failures on OpenShift.Acceptance tests changes
-enable-openshift
to the framework which will setglobal.openshift.enabled
to true for all helm installs/upgrades.CI changes